Generates Bitbucket Data Center PR URL and retrieves repoId for cross-forks #4184
+85
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
sergeibbb
force-pushed
the
bug/create-prs-bitbucket-dc
branch
from
df15357 to
2fea345
Compare
sergeibbb
added a commit
that referenced
this pull request
Mar 28, 2025
|
@sergeibbb can you rebase this? |
sergeibbb
added a commit
that referenced
this pull request
Apr 8, 2025
sergeibbb
force-pushed
the
bug/create-prs-bitbucket-dc
branch
from
2fea345 to
9872ed6
Compare
done |
eamodio
requested changes
Apr 8, 2025
src/git/remotes/remoteProvider.ts
Outdated
Comment on lines
190
to
195
| return this.splitArgPath(this.path); | ||
| } | ||
|
|
||
| protected splitArgPath(argPath: string): [string, string] { | ||
| const index = argPath.indexOf('/'); | ||
| return [argPath.substring(0, index), argPath.substring(index + 1)]; |
There was a problem hiding this comment.
Instead of adding a new splitArgPath function, what do you think of just making splitPath take a path and change current callers to pass in this.path? That would give the callers more control.
sergeibbb
force-pushed
the
bug/create-prs-bitbucket-dc
branch
from
9872ed6 to
526fe90
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
relates to #4142
Checklist
Fixes $XXX -orCloses #XXX -prefix to auto-close the issue that your PR addresses