Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Pull Request action fails for remotes other than GitHub #4142

Closed
8 tasks
eamodio opened this issue Mar 11, 2025 · 3 comments · Fixed by #4143 · May be fixed by #4184
Closed
8 tasks

Create Pull Request action fails for remotes other than GitHub #4142

eamodio opened this issue Mar 11, 2025 · 3 comments · Fixed by #4143 · May be fixed by #4184
Assignees
Labels
area-home Issues or features related to Home needs-verification Request for verification
Milestone

Comments

@eamodio
Copy link
Member

eamodio commented Mar 11, 2025

Description

We need to implement getUrlForCreatePullRequest for each supported remote

protected getUrlForCreatePullRequest?(
base: { branch?: string; remote: { path: string; url: string } },
compare: { branch: string; remote: { path: string; url: string } },
): string | undefined;

We need to also ensure that we are correctly mapping self-hosted provider remotes to the proper type

Verification steps

  • For Azure test different types of origin URL:
    • SSH VSTS (oldschool) [email protected]:v3/bbbchiv/MyFirstProject/test
    • SSH AzureDevOps (modern) [email protected]:v3/bbbchiv2/MyFirstProject/MyFirstProject
    • HTTPS VSTS (oldschool) https://bbbchiv.visualstudio.com/MyFirstProject/_git/test
    • HTTPS AzureDevOps (modern) https://[email protected]/bbbchiv2/MyFirstProject/_git/MyFirstProject
  • GitLab
  • Bitbucket Cloud
  • Bitbucket Data Center
  • GitHub.com and GitHub Enterprise
@eamodio eamodio added the area-home Issues or features related to Home label Mar 11, 2025
@eamodio eamodio added this to the 17.0 milestone Mar 11, 2025
eamodio added a commit that referenced this issue Mar 12, 2025
@eamodio
Copy link
Member Author

eamodio commented Mar 12, 2025

I started this here: #4143

@sambernaerdtphysibel
Copy link

Same problem here. "Create a Pull Request" is not doing anything on:

  • Cursor 0.46.11 (VSCode 1.96.2)
  • GitLens plugin 16.3.2
  • Azure DevOps

@sergeibbb sergeibbb self-assigned this Mar 12, 2025
sergeibbb added a commit that referenced this issue Mar 13, 2025
sergeibbb added a commit that referenced this issue Mar 17, 2025
sergeibbb added a commit that referenced this issue Mar 18, 2025
…rvices

Adds configuration options for comparison and create pull request URLs
to support custom remote services.

Updates the relevant interfaces and abstract methods to include
these new URL types.
(#4142, #4143)
sergeibbb added a commit that referenced this issue Mar 18, 2025
sergeibbb added a commit that referenced this issue Mar 18, 2025
sergeibbb added a commit that referenced this issue Mar 18, 2025
…rvices

Adds configuration options for comparison and create pull request URLs
to support custom remote services.

Updates the relevant interfaces and abstract methods to include
these new URL types.
(#4142, #4143)
sergeibbb added a commit that referenced this issue Mar 18, 2025
sergeibbb added a commit that referenced this issue Mar 19, 2025
sergeibbb added a commit that referenced this issue Mar 27, 2025
…rvices

Adds configuration options for comparison and create pull request URLs
to support custom remote services.

Updates the relevant interfaces and abstract methods to include
these new URL types.
(#4142, #4143)
sergeibbb added a commit that referenced this issue Mar 27, 2025
sergeibbb added a commit that referenced this issue Mar 27, 2025
axosoft-ramint pushed a commit that referenced this issue Mar 27, 2025
…rvices

Adds configuration options for comparison and create pull request URLs
to support custom remote services.

Updates the relevant interfaces and abstract methods to include
these new URL types.
(#4142, #4143)
axosoft-ramint pushed a commit that referenced this issue Mar 27, 2025
@github-actions github-actions bot added needs-verification Request for verification pending-release Resolved but not yet released to the stable edition labels Mar 27, 2025
@d13 d13 removed the pending-release Resolved but not yet released to the stable edition label Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-home Issues or features related to Home needs-verification Request for verification
Projects
None yet
4 participants