Adds support for comparison and create pull request URLs in remote services

Adds configuration options for comparison and create pull request URLs
to support custom remote services.

Updates the relevant interfaces and abstract methods to include
these new URL types.
(#4142, #4143)

Author: sergeibbb

package.json

@@ -3903,6 +3903,14 @@
 											"type": "string",
 											"markdownDescription": "Specifies the format of a commit URL for the custom remote service\n\nAvailable tokens\\\n`${repo}` — repository path\\\n`${id}` — commit SHA"
 										},
+										"comparison": {
+											"type": "string",
+											"markdownDescription": "Specifies the format of a comparison URL for the custom remote service\n\nAvailable tokens\\\n`${repo}` — repository path\\\n`${ref1}` — ref 1\\\n`${ref2}` — ref 2\\\n`${notation}` — notation"
+										},
+										"createPullRequest": {
+											"type": "string",
+											"markdownDescription": "Specifies the format of a create pull request URL for the custom remote service\n\nAvailable tokens\\\n`${repo}` — repository path\\\n`${base}` — base branch\\\n`${compare}` — compare branch"
+										},
 										"file": {
 											"type": "string",
 											"markdownDescription": "Specifies the format of a file URL for the custom remote service\n\nAvailable tokens\\\n`${repo}` — repository path\\\n`${file}` — file name\\\n`${line}` — formatted line information"

src/commands/createPullRequestOnRemote.ts

@@ -12,7 +12,7 @@ import { GlCommandBase } from './commandBase';
 import type { OpenOnRemoteCommandArgs } from './openOnRemote';
 
 export interface CreatePullRequestOnRemoteCommandArgs {
-	base?: string;
+	base: string | undefined;
 	compare: string;
 	remote: string;
 	repoPath: string;

src/config.ts

@@ -638,6 +638,7 @@ export interface RemotesUrlsConfig {
 	readonly branch: string;
 	readonly commit: string;
 	readonly comparison?: string;
+	readonly createPullRequest?: string;
 	readonly file: string;
 	readonly fileInBranch: string;
 	readonly fileInCommit: string;

src/git/models/remoteResource.ts

@@ -34,7 +34,7 @@ export type RemoteResource =
 	| {
 			type: RemoteResourceType.CreatePullRequest;
 			base: {
-				branch?: string;
+				branch: string | undefined;
 				remote: { path: string; url: string };
 			};
 			compare: {

src/git/remotes/gerrit.ts

@@ -189,6 +189,10 @@ export class GerritRemote extends RemoteProvider {
 		return this.encodeUrl(`${this.baseReviewUrl}/q/${sha}`);
 	}
 
+	protected override getUrlForComparison(base: string, head: string, notation: '..' | '...'): string | undefined {
+		return this.encodeUrl(`${this.baseReviewUrl}/q/${base}${notation}${head}`);
+	}
+
 	protected getUrlForFile(fileName: string, branch?: string, sha?: string, range?: Range): string {
 		const line = range != null ? `#${range.start.line}` : '';
 

src/git/remotes/remoteProvider.ts

@@ -129,7 +129,7 @@ export abstract class RemoteProvider<T extends ResourceDescriptor = ResourceDesc
 			case RemoteResourceType.Commit:
 				return this.getUrlForCommit(resource.sha);
 			case RemoteResourceType.Comparison: {
-				return this.getUrlForComparison?.(resource.base, resource.compare, resource.notation ?? '...');
+				return this.getUrlForComparison(resource.base, resource.compare, resource.notation ?? '...');
 			}
 			case RemoteResourceType.CreatePullRequest: {
 				return this.getUrlForCreatePullRequest?.(resource.base, resource.compare);
@@ -180,11 +180,12 @@ export abstract class RemoteProvider<T extends ResourceDescriptor = ResourceDesc
 
 	protected abstract getUrlForCommit(sha: string): string;
 
-	protected getUrlForComparison?(base: string, compare: string, notation: '..' | '...'): string | undefined;
+	protected abstract getUrlForComparison(base: string, head: string, notation: '..' | '...'): string | undefined;
 
 	protected getUrlForCreatePullRequest?(
 		base: { branch?: string; remote: { path: string; url: string } },
-		compare: { branch: string; remote: { path: string; url: string } },
+		head: { branch: string; remote: { path: string; url: string } },
+		options?: { title?: string; description?: string },
 	): string | undefined;
 
 	protected abstract getUrlForFile(fileName: string, branch?: string, sha?: string, range?: Range): string;