Correction regarding MBC2 RAM enable register #586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avivace
approved these changes
Feb 26, 2025
ISSOtm
requested changes
Mar 6, 2025
Co-authored-by: Eldred Habert <[email protected]>
avivace
approved these changes
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed because my emulator couldn't pass https://github.com/Gekkio/mooneye-test-suite/blob/main/emulator-only/mbc2/bits_ramg.s from the Mooneye test suite. Upon changing
val == 0xain my code toval&0xf == 0xait passes the test. I don't own a real Game Boy and haven't even looked into the test assembly so take this with a grain of salt.