Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: refactor forge for library use #10117

Merged
merged 7 commits into from
Mar 20, 2025
Merged

chore: refactor forge for library use #10117

merged 7 commits into from
Mar 20, 2025

Conversation

zerosnacks
Copy link
Member

@zerosnacks zerosnacks commented Mar 19, 2025 •
edited
Loading

Motivation

Ref: #9807

This will be applied in a similar manner for the other binaries in standalone PRs as the diffs can quickly grow very large

Solution

Make bin as thin as possible, move cmd, opts into the crate, create args to contain the subcommands

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@zerosnacks zerosnacks added C-forge Command: forge A-library Area: library labels Mar 19, 2025
@zerosnacks zerosnacks self-assigned this Mar 19, 2025
@zerosnacks zerosnacks mentioned this pull request Mar 19, 2025
Closed
4 tasks
@zerosnacks zerosnacks marked this pull request as ready for review March 19, 2025 11:52
@zerosnacks
Copy link
Member Author

zerosnacks commented Mar 19, 2025 •
edited
Loading

CI failure is unrelated (Alchemy keys..)

Pending #10120, marking as draft until then

@zerosnacks zerosnacks marked this pull request as draft March 19, 2025 13:27
@zerosnacks zerosnacks marked this pull request as ready for review March 19, 2025 14:35
@zerosnacks zerosnacks mentioned this pull request Mar 19, 2025
Merged
3 tasks
@zerosnacks zerosnacks added the T-chore Type: chore label Mar 19, 2025
grandizzy
grandizzy previously approved these changes Mar 19, 2025
View reviewed changes
Copy link
Collaborator

@grandizzy grandizzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@zerosnacks
Copy link
Member Author

small nit in 39230f4

moves run_command out of run to decouple the two and make it easier to invoke it in the context of a library with a typed command

@zerosnacks zerosnacks requested a review from grandizzy March 19, 2025 16:54
mattsse
mattsse approved these changes Mar 19, 2025
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense, changes lgtm

@zerosnacks zerosnacks merged commit db8b137 into master Mar 20, 2025
22 checks passed
@zerosnacks zerosnacks deleted the zerosnacks/refactor-forge-for-library-use branch March 20, 2025 08:14
This was referenced Mar 20, 2025
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@grandizzy grandizzy grandizzy approved these changes

@DaniPopes DaniPopes DaniPopes approved these changes

@klkvr klkvr Awaiting requested review from klkvr klkvr is a code owner

@yash-atreya yash-atreya Awaiting requested review from yash-atreya yash-atreya is a code owner

Assignees

@zerosnacks zerosnacks

Labels
A-library Area: library C-forge Command: forge T-chore Type: chore
Projects
Foundry
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zerosnacks @mattsse @grandizzy @DaniPopes