-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: refactor forge
for library use
#10117
Conversation
CI failure is unrelated (Alchemy keys..) Pending #10120, marking as draft until then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
… invoked outside of binary context
small nit in 39230f4 moves |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense, changes lgtm
Motivation
Ref: #9807
This will be applied in a similar manner for the other binaries in standalone PRs as the diffs can quickly grow very large
Solution
Make
bin
as thin as possible, movecmd
,opts
into the crate, createargs
to contain the subcommandsPR Checklist