Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor cast for library use #10123

Merged
merged 4 commits into from
Mar 20, 2025

Conversation

zerosnacks
Copy link
Member

Motivation

Ref: #9807
Ref: #10117

Solution

Make bin as thin as possible, move cmd, rename args to opts and move into the crate, create args to contain the subcommands

Remove vanity benchmark as it is unused and the way it imports caused issues

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@zerosnacks zerosnacks added C-cast Command: cast A-library Area: library labels Mar 19, 2025
@zerosnacks zerosnacks added the T-chore Type: chore label Mar 19, 2025
@zerosnacks zerosnacks marked this pull request as ready for review March 19, 2025 15:01
@zerosnacks zerosnacks self-assigned this Mar 19, 2025
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Collaborator

@grandizzy grandizzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@zerosnacks zerosnacks merged commit 530d6e5 into master Mar 20, 2025
22 checks passed
@zerosnacks zerosnacks deleted the zerosnacks/refactor-cast-for-library-use branch March 20, 2025 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-library Area: library C-cast Command: cast T-chore Type: chore
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants