Update the default frequently used reactions to look more like the reaction emojis #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In response to feedback around effectively "removing" the old quick reactions, we want to pre-seed the frequently used reactions with the old reactions.
There are a few quirks to this choice:
(1) we did not do the heavier work to make this per-entrypoint, so the normal "emoji" menu will also have these reactions, which may be less appropriate.
(2) if users have ever used the emoji menu before, their defaults would have already been saved. So this won't help some users.
Only the first 9 emoji are actually used, so I picked a couple extra to be in the main list.
https://app.asana.com/0/1147681086502841/1205817446804471/f
Test plan:
pointed local at this commit and saw the emojis render (after clearing the frequently used items from localStorage via
localStorage.removeItem('emoji-mart.frequently'))