Skip to content

Commit

Permalink
Update the default frequently used reactions to look more like the re…
Browse files Browse the repository at this point in the history
…action emojis (#22)

In response to feedback around effectively "removing" the old quick reactions, we want to pre-seed the frequently used reactions with the old reactions.

There are a few quirks to this choice:
(1) we did not do the heavier work to make this per-entrypoint, so the normal "emoji" menu will also have these reactions, which may be less appropriate.
(2) if users have ever used the emoji menu before, their defaults would have already been saved. So this won't help some users.

Only the first 9 emoji are actually used, so I picked a couple extra to be in the main list.

https://app.asana.com/0/1147681086502841/1205817446804471/f

Test plan:
pointed local at this commit and saw the emojis render (after clearing the frequently used items from localStorage via localStorage.removeItem('emoji-mart.frequently') )
  • Loading branch information
rj-figma authored Oct 31, 2023
1 parent 1e16c62 commit b227a1f
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 7 deletions.
2 changes: 1 addition & 1 deletion dist/index.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/index.js.map

Large diffs are not rendered by default.

11 changes: 6 additions & 5 deletions packages/emoji-mart/src/helpers/frequently-used.js
Original file line number Diff line number Diff line change
@@ -1,14 +1,15 @@
import { Store } from '../helpers'

const DEFAULTS = [
'heavy_plus_sign',
'+1',
'grinning',
'kissing_heart',
'-1',
'eyes',
'heart_eyes',
'laughing',
'stuck_out_tongue_winking_eye',
'sweat_smile',
'joy',
'fire',
'grinning',
'sweat_smile',
'scream',
'disappointed',
'unamused',
Expand Down

0 comments on commit b227a1f

Please sign in to comment.