This repository was archived by the owner on Oct 29, 2023. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 34
Preparing migration to Poetry #124
Draft
femueller
wants to merge
5
commits into
master
Choose a base branch
from
migrate-to-poetry
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
f79e98a
Preparing migration to Poetry
femueller 996e784
Update Makefile, typos and add .python-version file
femueller a507054
Release via 'poetry publish' instead of twine
femueller 8306978
Update Dockerfile
femueller 56fe8e5
Update Dockerfile
femueller File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,20 +6,11 @@ on: | |
- '*' | ||
|
||
jobs: | ||
deploy: | ||
build: | ||
runs-on: ubuntu-latest | ||
|
||
steps: | ||
- uses: actions/checkout@v3 | ||
- uses: actions/setup-python@v4 | ||
- name: Install dependencies | ||
run: | | ||
python -m pip install --upgrade pip | ||
pip install setuptools wheel twine | ||
- name: Build and publish | ||
env: | ||
TWINE_USERNAME: __token__ | ||
TWINE_PASSWORD: ${{ secrets.PYPI_PASSWORD }} | ||
run: | | ||
python setup.py sdist bdist_wheel | ||
twine upload dist/* | ||
- uses: actions/checkout@v3 | ||
- name: Build and publish to pypi | ||
uses: JRubics/[email protected] | ||
with: | ||
pypi_token: ${{ secrets.PYPI_TOKEN }} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
3.11 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -160,14 +160,14 @@ If there are any issues, bugs or missing API endpoints, feel free to contribute | |
|
||
### Run locally | ||
|
||
Prerequirements: [Pipenv](https://pipenv.readthedocs.io/) | ||
Prerequirements: [Poetry](https://python-poetry.org/) and | ||
|
||
```shell | ||
git clone [email protected]:femueller/python-n26.git | ||
cd python-n26 | ||
pipenv shell | ||
pipenv install | ||
python3 -m n26 balance | ||
poetry shell | ||
poetry install | ||
python -m n26 balance | ||
``` | ||
|
||
### Creating a new release (only for maintainers) | ||
|
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
[tool.poetry] | ||
name = "n26" | ||
version = "3.3.0" | ||
description = "Unofficial Python client for n26 (Number 26)" | ||
authors = ["femueller", "markusressel"] | ||
|
||
[tool.poetry.dependencies] | ||
python = "==3.11" | ||
click = "*" | ||
container-app-conf = "==5.*,>=5.2.0" | ||
inflect = "*" | ||
pycryptodome = ">=3.9" | ||
pyyaml = "*" | ||
requests = "==2.*,>=2.28.0" | ||
tabulate = ">=0.9.0" | ||
tenacity = "==8.*,>=8.1.0" | ||
urllib3 = "==1.*,>=1.26.0" | ||
|
||
[tool.poetry.dev-dependencies] | ||
flake8 = "*" | ||
mock = "*" | ||
pytest = "*" |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@markusressel I haven't used the Dockerfile yet. Is it from your perspective simple as that replacing
pipenv
withpoetry
in the Dockerfile?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No. Take a look at this one: https://github.com/ekeih/alerticular/blob/main/Dockerfile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The referenced Dockerfile uses Alpine as a base, which has its downsides, see: https://pythonspeed.com/articles/alpine-docker-python/
For a version based on buster, have a look at this one:
https://github.com/markusressel/openhasp-config-manager/blob/main/Dockerfile
The mentioned file is also used for a CLI tool, so it should be more fitting to python-n26 than the one from alerticular.