- Sponsor
-
Notifications
You must be signed in to change notification settings - Fork 34
Preparing migration to Poetry #124
base: master
Are you sure you want to change the base?
Conversation
Once the PyPI release process works via Poetry, we also don't need to generate a |
I went with this GitHub Action as it seems to be actively maintained and the most used for |
RUN pip install --upgrade pip;\ | ||
pip install pipenv;\ | ||
PIP_IGNORE_INSTALLED=1 pipenv install --system --deploy;\ | ||
pip install poetry;\ | ||
PIP_IGNORE_INSTALLED=1 poetry install;\ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@markusressel I haven't used the Dockerfile yet. Is it from your perspective simple as that replacing pipenv
with poetry
in the Dockerfile?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No. Take a look at this one: https://github.com/ekeih/alerticular/blob/main/Dockerfile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The referenced Dockerfile uses Alpine as a base, which has its downsides, see: https://pythonspeed.com/articles/alpine-docker-python/
For a version based on buster, have a look at this one:
https://github.com/markusressel/openhasp-config-manager/blob/main/Dockerfile
The mentioned file is also used for a CLI tool, so it should be more fitting to python-n26 than the one from alerticular.
Part of: #121
Done using Dephell:
What's missing:
Dockerfile
to use PoetryMakefile
to use Poetry