Skip to content
This repository was archived by the owner on Oct 29, 2023. It is now read-only.

Preparing migration to Poetry #124

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Preparing migration to Poetry #124

wants to merge 5 commits into from

Conversation

femueller
Copy link
Owner

@femueller femueller commented Feb 7, 2023

Part of: #121

Done using Dephell:

dephell deps convert --from=Pipfile --to-format=poetry --to-path=pyproject.toml

What's missing:

  • PyPI releases via Poetry
  • Modify Dockerfile to use Poetry
  • Modify Makefile to use Poetry

Sorry, something went wrong.

@femueller
Copy link
Owner Author

Once the PyPI release process works via Poetry, we also don't need to generate a requirements.txt anymore.

@femueller
Copy link
Owner Author

I went with this GitHub Action as it seems to be actively maintained and the most used for poetry publish. Still need to verify if it works as expected.

Comment on lines 13 to +15
RUN pip install --upgrade pip;\
pip install pipenv;\
PIP_IGNORE_INSTALLED=1 pipenv install --system --deploy;\
pip install poetry;\
PIP_IGNORE_INSTALLED=1 poetry install;\
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@markusressel I haven't used the Dockerfile yet. Is it from your perspective simple as that replacing pipenv with poetry in the Dockerfile?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

@markusressel markusressel Mar 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The referenced Dockerfile uses Alpine as a base, which has its downsides, see: https://pythonspeed.com/articles/alpine-docker-python/

For a version based on buster, have a look at this one:
https://github.com/markusressel/openhasp-config-manager/blob/main/Dockerfile

The mentioned file is also used for a CLI tool, so it should be more fitting to python-n26 than the one from alerticular.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants