Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spike error recovery integration #20602

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

chancancode
Copy link
Member

No description provided.

That's the actual feature we need, so if we can't/shouldn't upgrade we can just configure that plugin directly
@chancancode chancancode force-pushed the spike-error-recovery-integration branch 3 times, most recently from 2d8a515 to 6c41d9a Compare December 13, 2023 23:19
@chancancode
Copy link
Member Author

For anyone looking to test this, I pushed these pre-built dist that you can point your package.json at:

before: emberjs/ember.js#spike-error-recovery-integration-dist
after: emberjs/ember.js#spike-error-recovery-integration-baseline-dist

@NullVoxPopuli
Copy link
Contributor

Using those branches:

image

image

@NullVoxPopuli
Copy link
Contributor

NullVoxPopuli commented Dec 14, 2023

Before proceeding with perf comparisons, we probably need to look in to why the error-recovery assets are 86KB more than the baseline assets

@NullVoxPopuli NullVoxPopuli mentioned this pull request Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants