Error Recovery #20618
Draft
Error Recovery #20618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That's the actual feature we need, so if we can't/shouldn't upgrade we can just configure that plugin directly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #20602
by just rebasing as glimmer-vm upgrade was merged.
However, in order to test this branch, we'll still need to link glimmer-vm locally.
In order for this PR to progress, this needs to be merged:
glimmerjs/glimmer-vm#1501
But we don't yet know if it can be merged, due to perf concerns.
I have package.json refs/branches for testing perf:
"ember-source": "github:NullVoxPopuli/ember.js#main-dist","ember-source": "github:NullVoxPopuli/ember.js#error-recovery-dist",Both refs are created from
emberjs/ember.json their respectivemainvsspike-error-recovery-integrationbranches and thengit add ./dist -fto force-include the built assets on git.Results incoming.