Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ApplicationInstance#visit to use followRedirects() #20574

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update ApplicationInstance#visit to use followRedirects() #20574

wants to merge 2 commits into from

Commits on Aug 2, 2024

  1. Update ApplicationInstance#visit to use followRedirects() 

    The current implementation of `Transition#followRedirects()` is identical to the logic here: it catches rejections, and then checks for any other `activeTransition`. Therefore, this commit introduces no change in behavior.

But, if/when tildeio/router.js#335 lands, it will means we can take advantage of that fix for ApplicationInstance#visit.
    @davidtaylorhq @wagenet
    davidtaylorhq authored and wagenet committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    93fed52 View commit details
    Browse the repository at this point in the history

  2. Update router_js

    @wagenet
    wagenet committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    7fa758a View commit details
    Browse the repository at this point in the history