Update ApplicationInstance#visit to use followRedirects() #20574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current implementation of `Transition#followRedirects()` is identical to the logic here: it catches rejections, and then checks for any other `activeTransition`. Therefore, this commit introduces no change in behavior. But, if/when tildeio/router.js#335 lands, it will means we can take advantage of that fix for ApplicationInstance#visit.
wagenet
force-pushed
the
follow-redirects
branch
from
d364d09
to
7fa758a
Compare
|
The router.js fix has finally landed. I've pushed the version update to this branch as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of
Transition#followRedirects()is identical to the logic here: it catches rejections, and then checks for any otheractiveTransition. Therefore, this commit introduces no change in behavior.But, if/when tildeio/router.js#335 lands, it will means we can take advantage of that fix for ApplicationInstance#visit.