Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "KYC Status" and "Last Verified" columns #35797

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 18 additions & 11 deletions corehq/apps/integration/kyc/tables.py
Original file line number Diff line number Diff line change
Expand Up @@ -29,36 +29,43 @@ class Meta(BaseHtmxTable.Meta):
accessor='id',
attrs={
'th__input': {'name': 'select_all'},
}
},
)
first_name = columns.Column(
verbose_name=_("First Name"),
verbose_name=_('First Name'),
)
last_name = columns.Column(
verbose_name=_("Last Name"),
verbose_name=_('Last Name'),
)
phone_number = columns.Column(
verbose_name=_("Phone Number"),
verbose_name=_('Phone Number'),
)
email = columns.Column(
verbose_name=_("Email Address"),
verbose_name=_('Email Address'),
)
national_id_number = columns.Column(
verbose_name=_("National ID Number"),
verbose_name=_('National ID Number'),
)
street_address = columns.Column(
verbose_name=_("Street Address"),
verbose_name=_('Street Address'),
)
city = columns.Column(
verbose_name=_("City"),
verbose_name=_('City'),
)
post_code = columns.Column(
verbose_name=_("Post Code"),
verbose_name=_('Post Code'),
)
country = columns.Column(
verbose_name=_("Country"),
verbose_name=_('Country'),
)
kyc_is_verified = columns.TemplateColumn(
template_name='kyc/partials/kyc_verify_status.html',
verbose_name=_('KYC Status'),
)
kyc_last_verified_at = columns.DateTimeColumn(
verbose_name=_('Last Verified'),
)
verify_btn = columns.TemplateColumn(
template_name='kyc/partials/kyc_verify_button.html',
verbose_name=_("Verify"),
verbose_name=_('Verify'),
)
8 changes: 8 additions & 0 deletions corehq/apps/integration/kyc/tests/test_views.py
Original file line number Diff line number Diff line change
Expand Up @@ -245,6 +245,8 @@ def test_response_data_users(self):
'first_name': 'Jane',
'last_name': 'Doe',
'email': '',
'kyc_is_verified': None,
'kyc_last_verified_at': None,
}
else:
assert row == {
Expand All @@ -259,6 +261,8 @@ def test_response_data_users(self):
'city': 'Anytown',
'post_code': '12345',
'country': 'Anyplace',
'kyc_is_verified': None,
'kyc_last_verified_at': None,
}

@flag_enabled('KYC_VERIFICATION')
Expand Down Expand Up @@ -294,6 +298,8 @@ def test_response_data_cases(self):
'has_invalid_data': True,
'first_name': 'Foo',
'last_name': 'Bar',
'kyc_is_verified': None,
'kyc_last_verified_at': None,
}
else:
assert row == {
Expand All @@ -308,6 +314,8 @@ def test_response_data_cases(self):
'city': 'Sometown',
'post_code': '54321',
'country': 'Someplace',
'kyc_is_verified': None,
'kyc_last_verified_at': None,
}


Expand Down
10 changes: 8 additions & 2 deletions corehq/apps/integration/kyc/views.py
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ def _parse_row(self, row_obj, config):
'id': row_id,
'has_invalid_data': False,
}
user_fields = [
user_fields = (
'first_name',
'last_name',
'phone_number',
Expand All @@ -118,12 +118,18 @@ def _parse_row(self, row_obj, config):
'city',
'post_code',
'country',
]
)
system_fields = (
'kyc_is_verified',
'kyc_last_verified_at',
)
for field in user_fields:
if field not in user_data:
row_data['has_invalid_data'] = True
continue
row_data[field] = user_data[field]
for field in system_fields:
row_data[field] = user_data.get(field)
return row_data

@hq_hx_action('post')
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{% load i18n %}

{% if record.kyc_is_verified is True %}
<span class="badge bg-success">{% trans "Pass" %}</span>
{% elif record.kyc_is_verified is False %}
<span class="badge bg-danger">{% trans "Fail" }</span>
{% else %}
<span class="badge bg-secondary">{% trans "Not Checked" %}</span>
{% endif %}
Loading