Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "KYC Status" and "Last Verified" columns #35797

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

kaapstorm
Copy link
Contributor

@kaapstorm kaapstorm commented Feb 18, 2025

Technical Summary

This change adds "KYC Status" and "Last Verified" columns to the KYC report.

Jira: SC-4118

image
(Please ignoring the missing case property values. 🙈 )

🐡 🐠 🐬

Feature Flag

KYC_VERIFICATION

Safety Assurance

Safety story

Tested locally

Automated test coverage

This change is not covered by tests

QA Plan

No QA planned

Rollback instructions

  • This PR can be reverted after deploy with no further considerations

Labels & Review

  • Risk label is set correctly
  • The set of people pinged as reviewers is appropriate for the level of risk of the change

@kaapstorm kaapstorm added the product/invisible Change has no end-user visible impact label Feb 18, 2025
Copy link
Contributor

@zandre-eng zandre-eng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit, but otherwise looks good.

@@ -0,0 +1,7 @@
{% if record.kyc_is_verified is True %}
<span class="badge bg-success">Pass</span>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: I think it might be good to add translations for these status texts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product/invisible Change has no end-user visible impact
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants