feat(web-component): add base-cdn-url attribute #1013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
View your CI Pipeline Execution ↗ for commit b602969.
☁️ Nx Cloud last updated this comment at |
nirgur
reviewed
Feb 10, 2025
nirgur
approved these changes
Feb 10, 2025
asafshen
reviewed
Feb 10, 2025
| @@ -141,7 +141,7 @@ export const descopeUiMixin = createSingletonMixin( | |||
| this.#registerEvents(scriptEle); | |||
|
|
|||
| scriptEle.src = generateScriptUrl( | |||
| UI_COMPONENTS_URL, | |||
| this.baseCdnUrl || UI_COMPONENTS_URL, | |||
There was a problem hiding this comment.
we also need to expose this on high level sdk (react, etc)
omercnet
added a commit
that referenced
this pull request
Feb 11, 2025
followup on #1013 adding baseCdnUrl attribute anywhere descopeUi is used removing redundant baseStaticUrl mixin as it's already declared in the static resource mixin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Fixes https://github.com/descope/etc/issues/9009
Adding a way to customize CDN