Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add baseCdnUrl attribute in all packages #1014

Merged
merged 4 commits into from
Feb 11, 2025
Merged

Conversation

omercnet
Copy link
Member

@omercnet omercnet commented Feb 10, 2025

followup on #1013

adding baseCdnUrl attribute anywhere descopeUi is used
removing redundant baseStaticUrl mixin as it's already declared in the static resource mixin

Copy link

vercel bot commented Feb 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
access-key-management-widget ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 11, 2025 6:17am
audit-management-widget ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 11, 2025 6:17am
role-management-widget ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 11, 2025 6:17am
user-management-widget ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 11, 2025 6:17am
user-profile-widget ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 11, 2025 6:17am

Copy link

nx-cloud bot commented Feb 10, 2025

View your CI Pipeline Execution ↗ for commit 97ef586.

Command Status Duration Result
nx build:app user-profile-widget ✅ Succeeded 43s View ↗
nx build:app role-management-widget ✅ Succeeded 33s View ↗
nx build:app user-management-widget ✅ Succeeded 41s View ↗
nx build:app access-key-management-widget ✅ Succeeded 39s View ↗
nx build:app audit-management-widget ✅ Succeeded 31s View ↗

☁️ Nx Cloud last updated this comment at 2025-02-11 06:24:32 UTC

Copy link
Collaborator

@nirgur nirgur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but I think it's missing in some places

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants