Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(check): turn on noImplicitOverride #25695

Merged
merged 5 commits into from
Sep 18, 2024
Merged

feat(check): turn on noImplicitOverride #25695

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fc5182c
feat(check): turn on noImplicitOverride
bartlomieju Sep 17, 2024
8484492
fix tests
bartlomieju Sep 17, 2024
1b31b6d
use version
bartlomieju Sep 17, 2024
cf7d0b9
turn it in 99_main_compiler.js by default
bartlomieju Sep 17, 2024
a5f1d6f
add a test, make it work in the lsp
bartlomieju Sep 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion cli/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ winres.workspace = true
[dependencies]
deno_ast = { workspace = true, features = ["bundler", "cjs", "codegen", "proposal", "react", "sourcemap", "transforms", "typescript", "view", "visit"] }
deno_cache_dir = { workspace = true }
deno_config = { version = "=0.34.2", features = ["workspace", "sync"] }
deno_config = { version = "=0.34.3", features = ["workspace", "sync"] }
deno_core = { workspace = true, features = ["include_js_files_for_snapshotting"] }
deno_doc = { version = "0.148.0", features = ["html", "syntect"] }
deno_graph = { version = "=0.82.1" }
Expand Down
2 changes: 1 addition & 1 deletion cli/schemas/config-file.v1.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@
"noImplicitOverride": {
"description": "Ensure overriding members in derived classes are marked with an override modifier.",
"type": "boolean",
"default": false,
"default": true,
"markdownDescription": "Ensure overriding members in derived classes are marked with an override modifier.\n\nSee more: https://www.typescriptlang.org/tsconfig#noImplicitOverride"
},
"noImplicitReturns": {
Expand Down
4 changes: 2 additions & 2 deletions tests/unit/url_search_params_test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,7 +330,7 @@ Deno.test(
function urlSearchParamsOverridingAppendNotChangeConstructorAndSet() {
let overriddenAppendCalled = 0;
class CustomSearchParams extends URLSearchParams {
append(name: string, value: string) {
override append(name: string, value: string) {
++overriddenAppendCalled;
super.append(name, value);
}
Expand All @@ -345,7 +345,7 @@ Deno.test(

Deno.test(function urlSearchParamsOverridingEntriesNotChangeForEach() {
class CustomSearchParams extends URLSearchParams {
*entries(): IterableIterator<[string, string]> {
override *entries(): IterableIterator<[string, string]> {
yield* [];
}
}
Expand Down