Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(check): turn on noImplicitOverride #25695

Merged
merged 5 commits into from
Sep 18, 2024

Conversation

bartlomieju
Copy link
Member

@bartlomieju bartlomieju commented Sep 17, 2024

Depends on denoland/deno_config#115.

Closes #11836

Ref #25162

Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you also have to separately enable it for the LSP TS config

Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju bartlomieju merged commit 48ea4e3 into denoland:main Sep 18, 2024
17 checks passed
@bartlomieju bartlomieju deleted the feat_noImplicitOverride branch September 18, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider enabling "noImplicitOverride" by default
3 participants