Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wallixbastion 3.1.0 #38193

Merged
merged 9 commits into from
Jan 23, 2025
Merged

Wallixbastion 3.1.0 #38193

merged 9 commits into from
Jan 23, 2025

Conversation

yoennb
Copy link
Contributor

@yoennb yoennb commented Jan 16, 2025 •
edited
Loading

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

none

Description

This version adds several commands requested by our customers, adds more documentation on command outputs which may not always be present, and removes an unnecessary parameter from wab-add/edit-notification.

It also includes an update of the WALLIX logo.

Must have

  • Tests
  • Documentation

@CLAassistant
Copy link

CLAassistant commented Jan 16, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@content-bot content-bot added Contribution Thank you! Contributions are always welcome! External PR Partner Support Level Indicates that the contribution is for Partner supported pack labels Jan 16, 2025
@content-bot content-bot changed the base branch from master to contrib/wallix_wallixbastion-3.1.0 January 16, 2025 11:59
@content-bot content-bot requested a review from talzich January 16, 2025 11:59
@content-bot
Copy link
Collaborator

Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @talzich will know the proposed changes are ready to be reviewed.
For your convenience, here is a link to the contributions SLAs document.

@content-bot
Copy link
Collaborator

Hi @yoennb, thanks for contributing to the XSOAR marketplace. To receive credit for your generous contribution please follow this link.

@yoennb yoennb force-pushed the wallixbastion-3.1.0 branch from 6d72593 to c0bdf58 Compare January 16, 2025 12:01
@content-bot content-bot added Partner-Approved Contribution Form Filled Whether contribution form filled or not. Partner labels Jan 16, 2025
@yoennb
Copy link
Contributor Author

yoennb commented Jan 20, 2025

CI failing because of the mentioned breaking change. If this can cause issues, we can also mark the argument as deprecated (but I have not seen a field similar to the one that exists for commands)

@yoennb yoennb force-pushed the wallixbastion-3.1.0 branch from c0bdf58 to 320f175 Compare January 20, 2025 10:00
talzich
talzich reviewed Jan 20, 2025
View reviewed changes
Copy link
Contributor

@talzich talzich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @yoennb, and thank you for your contribution!

Other than the comment on the pack_metadata file, can you please elaborate on why the breaking change is needed and why those arguments are no longer in use?

Thanks again,
Tal

Packs/WALLIXBastion/pack_metadata.json Outdated
@@ -2,7 +2,7 @@
"name": "WALLIX Bastion",
"description": "Integrations for WALLIX Bastion appliances",
"support": "partner",
"currentVersion": "3.0.0",
"currentVersion": "3.1.0",
"author": "WALLIX",
"url": "https://www.wallix.com/privileged-access-management/",
"email": "",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you able to provide support email for this pack?

@yoennb
Copy link
Contributor Author

yoennb commented Jan 21, 2025

Hello @talzich,

It was noticed during the last PR review that this argument could only take a single value. I eventually confirmed with our teams that there is no plan to change this API any time soon, thus the decision to simply remove it for the sake of clarity.
If you prefer, we can also leave this argument as non required and explicitly state in the description that the value will be ignored.

Thanks,

Yoenn

@yoennb yoennb force-pushed the wallixbastion-3.1.0 branch from a89d85f to 83346ac Compare January 21, 2025 15:45
@talzich
Copy link
Contributor

talzich commented Jan 22, 2025 •
edited
Loading

Thanks for the clarification @yoennb !

I don't think we need to change anything, your solutions seems satisfactory, if it's good for you it's good for us.
Are you able to provide a short demo video showing the new commands in action or maybe we can schedule a quick zoom call?
Also, there's a pre-commit issue that's not related to the breaking changes, I can help you with that if we have a call.

cheers

@yoennb
Copy link
Contributor Author

yoennb commented Jan 22, 2025

Hello @talzich,

Perfect then, we can schedule a call in the coming days. I am available on Slack to discuss about it.

@yoennb yoennb force-pushed the wallixbastion-3.1.0 branch 2 times, most recently from 049b083 to 081a321 Compare January 23, 2025 14:59
@yoennb yoennb force-pushed the wallixbastion-3.1.0 branch from 081a321 to 16711ad Compare January 23, 2025 16:18
@talzich talzich merged commit 83c19b8 into demisto:contrib/wallix_wallixbastion-3.1.0 Jan 23, 2025
16 of 17 checks passed
@content-bot content-bot mentioned this pull request Jan 23, 2025
Merged
5 tasks
@github-actions GitHub Actions
Copy link

Thank you for your contribution. Your external PR has been merged and the changes are now included in an internal PR for further review. The internal PR will be merged to the master branch within 3 business days.

JudahSchwartz pushed a commit that referenced this pull request Jan 26, 2025
@content-bot @yoennb
Wallixbastion 3.1.0 (#38193) (#38302)
6863268 
* wallixbastion: update logos

* wallixbastion: update pack version

* wallixbastion: add new commands, document more outputs and remove notification_put_type from wab-add-notification & wab-edit-notification

* wallixbastion: update pack README

* wallixbastion: add email to pack metadata

* wallixbastion: update pack metadata description

* wallixbastion: fix typos in release notes

* wallixbastion: fix command wab-add-globald-omain when not using kerberos settings

* wallixbastion: add sections to WAB.yml

Co-authored-by: yoennb <[email protected]>
sdaniel6 pushed a commit that referenced this pull request Jan 27, 2025
@content-bot @yoennb @sdaniel6
Wallixbastion 3.1.0 (#38193) (#38302)
67a6eb3 
* wallixbastion: update logos

* wallixbastion: update pack version

* wallixbastion: add new commands, document more outputs and remove notification_put_type from wab-add-notification & wab-edit-notification

* wallixbastion: update pack README

* wallixbastion: add email to pack metadata

* wallixbastion: update pack metadata description

* wallixbastion: fix typos in release notes

* wallixbastion: fix command wab-add-globald-omain when not using kerberos settings

* wallixbastion: add sections to WAB.yml

Co-authored-by: yoennb <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@talzich talzich talzich approved these changes

Assignees

@talzich talzich

@edik24 edik24

Labels
Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! docs-approved External PR Partner Support Level Indicates that the contribution is for Partner supported pack Partner Partner-Approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yoennb @CLAassistant @content-bot @talzich @edik24