Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wallixbastion 3.1.0 #38302

Merged
merged 1 commit into from
Jan 26, 2025
Merged

Conversation

content-bot
Copy link
Collaborator

Original External PR

external pull request

Contributor

@yoennb

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

none

Description

This version adds several commands requested by our customers, adds more documentation on command outputs which may not always be present, and removes an unnecessary parameter from wab-add/edit-notification.

It also includes an update of the WALLIX logo.

Must have

  • Tests
  • Documentation

* wallixbastion: update logos

* wallixbastion: update pack version

* wallixbastion: add new commands, document more outputs and remove notification_put_type from wab-add-notification & wab-edit-notification

* wallixbastion: update pack README

* wallixbastion: add email to pack metadata

* wallixbastion: update pack metadata description

* wallixbastion: fix typos in release notes

* wallixbastion: fix command wab-add-globald-omain when not using kerberos settings

* wallixbastion: add sections to WAB.yml
@content-bot content-bot added Contribution Thank you! Contributions are always welcome! docs-approved Partner Contribution Form Filled Whether contribution form filled or not. Partner Support Level Indicates that the contribution is for Partner supported pack Internal PR Partner-Approved labels Jan 23, 2025
@content-bot content-bot requested a review from talzich January 23, 2025 16:41
Copy link

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/WALLIXBastion/Integrations/WAB
   WAB.py18383997%22, 30–32, 39–41, 48–50, 57–59, 70–71, 87, 90–92, 100, 109, 127–128, 141, 172, 3770–3772, 3774, 3782, 3786–3787, 3816, 3831–3832, 3845, 4057, 4059–4060
TOTAL18383997% 

Tests Skipped Failures Errors Time
5 0 💤 0 ❌ 0 🔥 5.815s ⏱️

@talzich talzich added the ForceMerge Forcing the merge of the PR despite the build status label Jan 26, 2025
@talzich
Copy link
Contributor

talzich commented Jan 26, 2025

@JudahSchwartz We need force merge here. Changes are breaking BC. The reasoning behind it could be found in the external PR.

@JudahSchwartz JudahSchwartz merged commit 6863268 into master Jan 26, 2025
43 of 45 checks passed
@JudahSchwartz JudahSchwartz deleted the contrib/wallix_wallixbastion-3.1.0 branch January 26, 2025 09:17
sdaniel6 pushed a commit that referenced this pull request Jan 27, 2025
* wallixbastion: update logos

* wallixbastion: update pack version

* wallixbastion: add new commands, document more outputs and remove notification_put_type from wab-add-notification & wab-edit-notification

* wallixbastion: update pack README

* wallixbastion: add email to pack metadata

* wallixbastion: update pack metadata description

* wallixbastion: fix typos in release notes

* wallixbastion: fix command wab-add-globald-omain when not using kerberos settings

* wallixbastion: add sections to WAB.yml

Co-authored-by: yoennb <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! docs-approved ForceMerge Forcing the merge of the PR despite the build status Internal PR Partner Support Level Indicates that the contribution is for Partner supported pack Partner Partner-Approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants