-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move dependency management and plugin management to parent pom #1260
base: master
Are you sure you want to change the base?
Move dependency management and plugin management to parent pom #1260
Conversation
Signed-off-by: sirivarma <[email protected]>
Signed-off-by: sirivarma <[email protected]>
Signed-off-by: sirivarma <[email protected]>
Signed-off-by: sirivarma <[email protected]>
Signed-off-by: sirivarma <[email protected]>
c897dec
to
d2ecf18
Compare
Signed-off-by: sirivarma <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@siri-varma thank you so much for this effort. I have added a few comments. Mainly I want to ensure that if you went through the trouble of extracting some of version properties you should make sure that all dependency versions are extracted.
Also we should double check that the right scopes are used, so we don't accidentally pack dependencies that should not be deployed to Maven Central.
Signed-off-by: Siri Varma Vegiraju <[email protected]>
@cicoyle Would you be able to approve the build on this PR please ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving for CI
@siri-varma could you please verify this failing CI runs: https://github.com/dapr/java-sdk/actions/runs/13902606663/job/38899059339?pr=1260. It seems that there are some issue with Dapr IT tests that can be found in |
Signed-off-by: Siri Varma Vegiraju <[email protected]>
Signed-off-by: siri-varma <[email protected]>
Signed-off-by: Siri Varma Vegiraju <[email protected]> Signed-off-by: siri-varma <[email protected]>
Signed-off-by: siri-varma <[email protected]>
Signed-off-by: siri-varma <[email protected]>
…factor-pom-1
@artur-ciocanu thanks for taking the time to review. There were two sets of error
Will need the approval again for the build to run. Thank you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-approving for CI
Signed-off-by: sirivarma <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reapproving for CI
@artur-ciocanu Finally ! These changes are good to go. Thanks a ton for reapproving the CI build multiple times. |
@cicoyle could you please take a look and approve if things look good. Thank you! |
/assign |
@@ -33,6 +33,7 @@ | |||
<logback-core.version>1.5.16</logback-core.version> | |||
<wiremock.version>3.9.1</wiremock.version> | |||
<testcontainers-test.version>1.20.0</testcontainers-test.version> | |||
<jacoco-maven-plugin.coverage-ratio>0%</jacoco-maven-plugin.coverage-ratio> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@siri-varma I am a bit lost.. why is this 0% ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The JaCoCo plugin was expecting coverage for this module, but since it's a test module and code coverage typically doesn't apply to tests, I set the coverage to 0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a comment noting this for future reference?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@siri-varma I've added a few comments.. apologies for the delay.
Signed-off-by: sirivarma <[email protected]>
…iri-varma/java-sdk into users/svegiraju/refactor-pom-1
@salaboy addressed all the comments |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve for CI
Thank you for approving Artur. I think the build failed because of the flaky integration test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment if you can add a comment in code around the 0%
test coverage area for future reference
Signed-off-by: sirivarma <[email protected]>
Signed-off-by: sirivarma <[email protected]>
…iri-varma/java-sdk into users/svegiraju/refactor-pom-1
@cicoyle done. Added the comment |
@salaboy the build is 🟢 could you please take another look and see if everything looks good, so we could merge this PR. |
Description
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #940
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: