Skip to content

Commit 7134837

Browse files
Address comments
Signed-off-by: Siri Varma Vegiraju <[email protected]>
1 parent c49af42 commit 7134837

File tree

1 file changed

+14
-12
lines changed

1 file changed

+14
-12
lines changed

pom.xml

+14-12
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,9 @@
2626
<maven-deploy-plugin.version>2.7</maven-deploy-plugin.version>
2727
<maven-resources-plugin.version>3.3.1</maven-resources-plugin.version>
2828
<maven-compiler-plugin.version>3.13.0</maven-compiler-plugin.version>
29+
<maven-sources-plugin.version>3.2.1</maven-sources-plugin.version>
30+
<jacoco-maven-plugin.version>0.8.11</jacoco-maven-plugin.version>
31+
<jacoco-maven-plugin.coverage-ratio>80%</jacoco-maven-plugin.coverage-ratio>
2932
<maven.compiler.source>11</maven.compiler.source>
3033
<maven.compiler.target>11</maven.compiler.target>
3134
<maven.compiler.release>11</maven.compiler.release>
@@ -138,32 +141,32 @@
138141
<dependency>
139142
<groupId>org.junit.jupiter</groupId>
140143
<artifactId>junit-jupiter</artifactId>
141-
<version>5.11.4</version>
144+
<version>${junit-bom.version}</version>
142145
</dependency>
143146
<dependency>
144147
<groupId>org.junit.jupiter</groupId>
145148
<artifactId>junit-jupiter-api</artifactId>
146-
<version>5.11.4</version>
149+
<version>${junit-bom.version}</version>
147150
</dependency>
148151
<dependency>
149152
<groupId>org.junit.jupiter</groupId>
150153
<artifactId>junit-jupiter-engine</artifactId>
151-
<version>5.11.4</version>
154+
<version>${junit-bom.version}</version>
152155
</dependency>
153156
<dependency>
154157
<groupId>org.junit.jupiter</groupId>
155158
<artifactId>junit-jupiter-params</artifactId>
156-
<version>5.11.4</version>
159+
<version>${junit-bom.version}</version>
157160
</dependency>
158161
<dependency>
159162
<groupId>org.testcontainers</groupId>
160163
<artifactId>junit-jupiter</artifactId>
161-
<version>1.19.8</version>
164+
<version>${testcontainers.version}</version>
162165
</dependency>
163166
<dependency>
164167
<groupId>org.testcontainers</groupId>
165168
<artifactId>kafka</artifactId>
166-
<version>1.20.0</version>
169+
<version>${testcontainers.version}</version>
167170
</dependency>
168171
<dependency>
169172
<groupId>org.springframework.boot</groupId>
@@ -174,18 +177,17 @@
174177
<dependency>
175178
<groupId>org.testcontainers</groupId>
176179
<artifactId>postgresql</artifactId>
177-
<version>1.20.0</version>
180+
<version>${testcontainers.version}</version>
178181
</dependency>
179182
<dependency>
180183
<groupId>org.testcontainers</groupId>
181184
<artifactId>rabbitmq</artifactId>
182-
<version>1.20.0</version>
185+
<version>${testcontainers.version}</version>
183186
</dependency>
184187
<dependency>
185188
<groupId>io.rest-assured</groupId>
186189
<artifactId>rest-assured</artifactId>
187190
<version>5.5.1</version>
188-
<scope>test</scope>
189191
</dependency>
190192
<dependency>
191193
<groupId>io.dapr.spring</groupId>
@@ -226,7 +228,7 @@
226228
<plugin>
227229
<groupId>org.apache.maven.plugins</groupId>
228230
<artifactId>maven-source-plugin</artifactId>
229-
<version>3.2.1</version>
231+
<version>${maven-sources-plugin.version}</version>
230232
</plugin>
231233
<plugin>
232234
<groupId>org.apache.maven.plugins</groupId>
@@ -279,7 +281,7 @@
279281
<plugin>
280282
<groupId>org.jacoco</groupId>
281283
<artifactId>jacoco-maven-plugin</artifactId>
282-
<version>0.8.11</version>
284+
<version>${jacoco-maven-plugin.version}</version>
283285
<executions>
284286
<execution>
285287
<id>default-prepare-agent</id>
@@ -310,7 +312,7 @@
310312
<limit>
311313
<counter>LINE</counter>
312314
<value>COVEREDRATIO</value>
313-
<minimum>80%</minimum>
315+
<minimum>${jacoco-maven-plugin.coverage-ratio}</minimum>
314316
</limit>
315317
</limits>
316318
</rule>

0 commit comments

Comments
 (0)