[components] Move dagster_components.lib components to top-level #28092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| @@ -1,4 +1,4 @@ | |||
| type: dagster_components.lib.DbtProjectComponent | |||
| type: dagster_components..DbtProjectComponent | |||
There was a problem hiding this comment.
There appears to be a duplicate period in the component type path dagster_components..DbtProjectComponent. This should be dagster_components.DbtProjectComponent. This typo appears in several test files and should be fixed to maintain consistency with the new import structure.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
|
Deploy preview for dagster-docs ready! Preview available at https://dagster-docs-i5tjhbbss-elementl.vercel.app Direct link to changed pages: |
smackesey
force-pushed
the
sean/components/move-components-to-top-level
branch
3 times, most recently
from
058cacc to
5d21704
Compare
smackesey
force-pushed
the
sean/components/move-test-components-to-tests
branch
2 times, most recently
from
2284e30 to
0becc96
Compare
smackesey
force-pushed
the
sean/components/move-components-to-top-level
branch
2 times, most recently
from
751a83c to
ed36797
Compare
smackesey
force-pushed
the
sean/components/move-test-components-to-tests
branch
from
0becc96 to
bb0f1bf
Compare
smackesey
force-pushed
the
sean/components/move-components-to-top-level
branch
from
ed36797 to
bc8a72f
Compare
smackesey
force-pushed
the
sean/components/move-test-components-to-tests
branch
2 times, most recently
from
1e06ab0 to
56af59b
Compare
smackesey
force-pushed
the
sean/components/move-components-to-top-level
branch
2 times, most recently
from
eede618 to
113227b
Compare
smackesey
force-pushed
the
sean/components/move-test-components-to-tests
branch
from
56af59b to
01cfc9c
Compare
Base automatically changed from
sean/components/move-test-components-to-tests
to
master
February 27, 2025 21:40
smackesey
force-pushed
the
sean/components/move-components-to-top-level
branch
from
113227b to
9b4cbb6
Compare
smackesey
force-pushed
the
sean/components/move-components-to-top-level
branch
from
9b4cbb6 to
1291ed3
Compare
smackesey
force-pushed
the
sean/components/move-components-to-top-level
branch
from
bce7e33 to
c51ba3a
Compare
smackesey
force-pushed
the
sean/components/move-components-to-top-level
branch
from
c51ba3a to
7bbe1e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Breaks up the public
dagster_componentsentry point into three library-specific entry points. Names have changed as follows:dagster_components.PipesSubprocessScriptCollectionComponent->dagster_components.dagster.PipesSubprocessScriptCollectionComponentdagster_components.DefinitionsComponent->dagster_components.dagster.DefinitionsComponentdagster_components.DbtProjectComponent->dagster_components.dagster_dbt.DbtProjectComponentdagster_components.SlingReplicationCollectionComponent->dagster_components.dagster_sling.SlingReplicationCollectionComponentHow I Tested These Changes
Existing test suite.