-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[components] Move dagster_components.lib components to top-level (#28092
) ## Summary & Motivation Breaks up the public `dagster_components` entry point into three library-specific entry points. Names have changed as follows: - `dagster_components.PipesSubprocessScriptCollectionComponent` -> `dagster_components.dagster.PipesSubprocessScriptCollectionComponent` - `dagster_components.DefinitionsComponent` -> `dagster_components.dagster.DefinitionsComponent` - `dagster_components.DbtProjectComponent` -> `dagster_components.dagster_dbt.DbtProjectComponent` - `dagster_components.SlingReplicationCollectionComponent` -> `dagster_components.dagster_sling.SlingReplicationCollectionComponent` ## How I Tested These Changes Existing test suite.
- Loading branch information
Showing
56 changed files
with
231 additions
and
193 deletions.
There are no files selected for viewing
2 changes: 1 addition & 1 deletion
2
...docs_beta_snippets/docs_beta_snippets/guides/components/custom-subclass/basic-subclass.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
from dagster_components.lib import SlingReplicationCollectionComponent | ||
from dagster_components.dagster_sling import SlingReplicationCollectionComponent | ||
|
||
|
||
class CustomSubclass(SlingReplicationCollectionComponent): ... |
2 changes: 1 addition & 1 deletion
2
...s/docs_beta_snippets/docs_beta_snippets/guides/components/custom-subclass/custom-scope.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
...les/docs_beta_snippets/docs_beta_snippets/guides/components/custom-subclass/debug-mode.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
25 changes: 13 additions & 12 deletions
25
...ppets/docs_beta_snippets/guides/components/existing-project/8-dg-list-component-types.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,15 +1,16 @@ | ||
dg list component-type | ||
|
||
Using /.../my-existing-project/.venv/bin/dagster-components | ||
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━┓ | ||
┃ Component Type ┃ Summary ┃ | ||
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━┩ | ||
│ dagster_components.lib.DefinitionsComponent │ Wraps an arbitrary │ | ||
│ │ set of Dagster │ | ||
│ │ definitions. │ | ||
│ dagster_components.lib.PipesSubprocessScriptCollectionComponent │ Assets that wrap │ | ||
│ │ Python scripts │ | ||
│ │ executed with │ | ||
│ │ Dagster's │ | ||
│ │ PipesSubprocessClie… │ | ||
└─────────────────────────────────────────────────────────────────┴──────────────────────┘ | ||
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━┓ | ||
┃ Component Type ┃ Summary ┃ | ||
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━┩ | ||
│ dagster_components.dagster.DefinitionsComponent │ Wraps an │ | ||
│ │ arbitrary set of │ | ||
│ │ Dagster │ | ||
│ │ definitions. │ | ||
│ dagster_components.dagster.PipesSubprocessScriptCollectionComponent │ Assets that wrap │ | ||
│ │ Python scripts │ | ||
│ │ executed with │ | ||
│ │ Dagster's │ | ||
│ │ PipesSubprocess… │ | ||
└─────────────────────────────────────────────────────────────────────┴──────────────────┘ |
2 changes: 1 addition & 1 deletion
2
examples/docs_beta_snippets/docs_beta_snippets/guides/components/index/11-component.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
42 changes: 23 additions & 19 deletions
42
...s_beta_snippets/docs_beta_snippets/guides/components/index/18-dg-list-component-types.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,22 +1,26 @@ | ||
dg list component-type | ||
|
||
Using /.../jaffle-platform/.venv/bin/dagster-components | ||
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━┓ | ||
┃ Component Type ┃ Summary ┃ | ||
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━┩ | ||
│ dagster_components.lib.DbtProjectComponent │ Expose a DBT project │ | ||
│ │ to Dagster as a set │ | ||
│ │ of assets. │ | ||
│ dagster_components.lib.DefinitionsComponent │ Wraps an arbitrary │ | ||
│ │ set of Dagster │ | ||
│ │ definitions. │ | ||
│ dagster_components.lib.PipesSubprocessScriptCollectionComponent │ Assets that wrap │ | ||
│ │ Python scripts │ | ||
│ │ executed with │ | ||
│ │ Dagster's │ | ||
│ │ PipesSubprocessClie… │ | ||
│ dagster_components.lib.SlingReplicationCollectionComponent │ Expose one or more │ | ||
│ │ Sling replications │ | ||
│ │ to Dagster as │ | ||
│ │ assets. │ | ||
└─────────────────────────────────────────────────────────────────┴──────────────────────┘ | ||
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━┓ | ||
┃ Component Type ┃ Summary ┃ | ||
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━┩ | ||
│ dagster_components.dagster.DefinitionsComponent │ Wraps an │ | ||
│ │ arbitrary set │ | ||
│ │ of Dagster │ | ||
│ │ definitions. │ | ||
│ dagster_components.dagster.PipesSubprocessScriptCollectionComponent │ Assets that │ | ||
│ │ wrap Python │ | ||
│ │ scripts │ | ||
│ │ executed with │ | ||
│ │ Dagster's │ | ||
│ │ PipesSubproces… │ | ||
│ dagster_components.dagster_dbt.DbtProjectComponent │ Expose a DBT │ | ||
│ │ project to │ | ||
│ │ Dagster as a │ | ||
│ │ set of assets. │ | ||
│ dagster_components.dagster_sling.SlingReplicationCollectionComponent │ Expose one or │ | ||
│ │ more Sling │ | ||
│ │ replications to │ | ||
│ │ Dagster as │ | ||
│ │ assets. │ | ||
└──────────────────────────────────────────────────────────────────────┴─────────────────┘ |
2 changes: 1 addition & 1 deletion
2
...les/docs_beta_snippets/docs_beta_snippets/guides/components/index/19-dg-scaffold-jdbt.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
dg scaffold component dagster_components.lib.DbtProjectComponent jdbt --project-path dbt/jdbt | ||
dg scaffold component dagster_components.dagster_dbt.DbtProjectComponent jdbt --project-path dbt/jdbt | ||
|
||
Creating a Dagster component instance folder at /.../jaffle-platform/jaffle_platform/defs/jdbt. | ||
Using /.../jaffle-platform/.venv/bin/dagster-components |
2 changes: 1 addition & 1 deletion
2
...ples/docs_beta_snippets/docs_beta_snippets/guides/components/index/20-component-jdbt.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
examples/docs_beta_snippets/docs_beta_snippets/guides/components/index/23-project-jdbt.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
25 changes: 13 additions & 12 deletions
25
...cs_beta_snippets/docs_beta_snippets/guides/components/index/7-dg-list-component-types.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,14 +1,15 @@ | ||
dg list component-type | ||
|
||
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━┓ | ||
┃ Component Type ┃ Summary ┃ | ||
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━┩ | ||
│ dagster_components.lib.DefinitionsComponent │ Wraps an arbitrary │ | ||
│ │ set of Dagster │ | ||
│ │ definitions. │ | ||
│ dagster_components.lib.PipesSubprocessScriptCollectionComponent │ Assets that wrap │ | ||
│ │ Python scripts │ | ||
│ │ executed with │ | ||
│ │ Dagster's │ | ||
│ │ PipesSubprocessClie… │ | ||
└─────────────────────────────────────────────────────────────────┴──────────────────────┘ | ||
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━┓ | ||
┃ Component Type ┃ Summary ┃ | ||
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━┩ | ||
│ dagster_components.dagster.DefinitionsComponent │ Wraps an │ | ||
│ │ arbitrary set of │ | ||
│ │ Dagster │ | ||
│ │ definitions. │ | ||
│ dagster_components.dagster.PipesSubprocessScriptCollectionComponent │ Assets that wrap │ | ||
│ │ Python scripts │ | ||
│ │ executed with │ | ||
│ │ Dagster's │ | ||
│ │ PipesSubprocess… │ | ||
└─────────────────────────────────────────────────────────────────────┴──────────────────┘ |
35 changes: 19 additions & 16 deletions
35
...cs_beta_snippets/docs_beta_snippets/guides/components/index/8-dg-list-component-types.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,19 +1,22 @@ | ||
dg list component-type | ||
|
||
Using /.../jaffle-platform/.venv/bin/dagster-components | ||
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━┓ | ||
┃ Component Type ┃ Summary ┃ | ||
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━┩ | ||
│ dagster_components.lib.DefinitionsComponent │ Wraps an arbitrary │ | ||
│ │ set of Dagster │ | ||
│ │ definitions. │ | ||
│ dagster_components.lib.PipesSubprocessScriptCollectionComponent │ Assets that wrap │ | ||
│ │ Python scripts │ | ||
│ │ executed with │ | ||
│ │ Dagster's │ | ||
│ │ PipesSubprocessClie… │ | ||
│ dagster_components.lib.SlingReplicationCollectionComponent │ Expose one or more │ | ||
│ │ Sling replications │ | ||
│ │ to Dagster as │ | ||
│ │ assets. │ | ||
└─────────────────────────────────────────────────────────────────┴──────────────────────┘ | ||
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━┓ | ||
┃ Component Type ┃ Summary ┃ | ||
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━┩ | ||
│ dagster_components.dagster.DefinitionsComponent │ Wraps an │ | ||
│ │ arbitrary set │ | ||
│ │ of Dagster │ | ||
│ │ definitions. │ | ||
│ dagster_components.dagster.PipesSubprocessScriptCollectionComponent │ Assets that │ | ||
│ │ wrap Python │ | ||
│ │ scripts │ | ||
│ │ executed with │ | ||
│ │ Dagster's │ | ||
│ │ PipesSubproces… │ | ||
│ dagster_components.dagster_sling.SlingReplicationCollectionComponent │ Expose one or │ | ||
│ │ more Sling │ | ||
│ │ replications to │ | ||
│ │ Dagster as │ | ||
│ │ assets. │ | ||
└──────────────────────────────────────────────────────────────────────┴─────────────────┘ |
2 changes: 1 addition & 1 deletion
2
...a_snippets/docs_beta_snippets/guides/components/index/9-dg-scaffold-sling-replication.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
dg scaffold component 'dagster_components.lib.SlingReplicationCollectionComponent' ingest_files | ||
dg scaffold component 'dagster_components.dagster_sling.SlingReplicationCollectionComponent' ingest_files | ||
|
||
Creating a Dagster component instance folder at /.../jaffle-platform/jaffle_platform/defs/ingest_files. | ||
Using /.../jaffle-platform/.venv/bin/dagster-components |
2 changes: 1 addition & 1 deletion
2
...s_beta_snippets/docs_beta_snippets/guides/components/migrating-definitions/3-scaffold.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
..._snippets/docs_beta_snippets/guides/components/migrating-definitions/6-component-yaml.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
type: dagster_components.lib.DefinitionsComponent | ||
type: dagster_components.dagster.DefinitionsComponent | ||
|
||
attributes: | ||
definitions_path: definitions.py |
2 changes: 1 addition & 1 deletion
2
...es/docs_beta_snippets/docs_beta_snippets/guides/components/python-components/component.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
2d7e382
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deploy preview for dagster-docs ready!
✅ Preview
https://dagster-docs-cdelrifmc-elementl.vercel.app
Built with commit 2d7e382.
This pull request is being automatically deployed with vercel-action