Update docs to reflect pools concept for concurrency #27171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 16, 2025
|
Deploy preview for dagster-university ready! ✅ Preview Built with commit aa5ef8c. |
|
Deploy preview for dagster-docs ready! Preview available at https://dagster-docs-kvt9hmzdc-elementl.vercel.app Direct link to changed pages: |
prha
force-pushed
the
prha/run_pools_ui
branch
from
840e884 to
558acb1
Compare
prha
force-pushed
the
prha/concurrency_docs
branch
from
aa5ef8c to
c15ed10
Compare
prha
changed the title
prha
force-pushed
the
prha/concurrency_docs
branch
from
c15ed10 to
45ed699
Compare
prha
force-pushed
the
prha/run_pools_ui
branch
from
558acb1 to
a169ead
Compare
prha
force-pushed
the
prha/concurrency_docs
branch
from
45ed699 to
520a23a
Compare
prha
force-pushed
the
prha/run_pools_ui
branch
from
a169ead to
9db7df6
Compare
prha
force-pushed
the
prha/concurrency_docs
branch
from
520a23a to
8b6dbf2
Compare
prha
force-pushed
the
prha/run_pools_ui
branch
from
9db7df6 to
3fdabb4
Compare
prha
force-pushed
the
prha/concurrency_docs
branch
from
8b6dbf2 to
895f9e5
Compare
prha
force-pushed
the
prha/run_pools_ui
branch
from
3fdabb4 to
ffc15a7
Compare
prha
force-pushed
the
prha/concurrency_docs
branch
from
895f9e5 to
6e54cc9
Compare
prha
force-pushed
the
prha/run_pools_ui
branch
from
ffc15a7 to
3e86416
Compare
prha
force-pushed
the
prha/run_pools_ui
branch
from
30ce73f to
49a6f83
Compare
prha
force-pushed
the
prha/concurrency_docs
branch
from
09a67d1 to
e2f8e3b
Compare
prha
force-pushed
the
prha/run_pools_ui
branch
from
49a6f83 to
9f644f3
Compare
prha
force-pushed
the
prha/concurrency_docs
branch
from
e2f8e3b to
b027576
Compare
prha
force-pushed
the
prha/run_pools_ui
branch
from
9f644f3 to
9c9353d
Compare
prha
force-pushed
the
prha/concurrency_docs
branch
from
b027576 to
c744c73
Compare
prha
force-pushed
the
prha/run_pools_ui
branch
from
9c9353d to
c5ff268
Compare
prha
force-pushed
the
prha/concurrency_docs
branch
from
c744c73 to
6b99141
Compare
prha
force-pushed
the
prha/run_pools_ui
branch
from
c5ff268 to
cb49dbb
Compare
prha
force-pushed
the
prha/concurrency_docs
branch
from
6b99141 to
212f85d
Compare
prha
force-pushed
the
prha/run_pools_ui
branch
2 times, most recently
from
777f054 to
dbe80cb
Compare
prha
force-pushed
the
prha/concurrency_docs
branch
from
212f85d to
cca96cd
Compare
prha
force-pushed
the
prha/concurrency_docs
branch
from
cca96cd to
e1e5d2b
Compare
neverett
reviewed
Feb 10, 2025
| @@ -0,0 +1,28 @@ | |||
| import time | |||
There was a problem hiding this comment.
I would rename the tbd directory to operate for consistency with the docs. (The code snippets directories are kind of a mess right now, unfortunately.)
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
|
|
||
| For example, you might want to limit the number of ops or assets that are running with a key of `database` across all runs (to limit the load on that database). | ||
| Once you have assigned your assets and ops to a concurrency pool, you can configure a pool limit for that pool in your deployment by using the Dagster UI or by using the Dagster CLI. |
There was a problem hiding this comment.
Change 'CLI' to lowercase 'cli' for consistency with documentation standards
Spotted by Graphite Reviewer (based on CI logs)
Is this helpful? React 👍 or 👎 to let us know.
prha
force-pushed
the
prha/concurrency_docs
branch
from
922963b to
cf54b0a
Compare
prha
force-pushed
the
prha/concurrency_docs
branch
from
cf54b0a to
ee26162
Compare
neverett
reviewed
Feb 10, 2025
|
|
||
| You can configure a limit for runs that are tagged with a specific tag key or key-value pair. | ||
| <CodeExample filePath="docs_beta_snippets/docs_beta_snippets/guides/operate/concurrency-pool-api.py" language="python" title="Specifying pools on assets and ops" /> |
There was a problem hiding this comment.
Sorry, I suggested the wrong property earlier -- this should be path instead of filePath
prha
added a commit
that referenced
this pull request
Feb 10, 2025
## Summary & Motivation Changes the docs to include the pools concept ## How I Tested These Changes Inspection
LoHertel
pushed a commit
to LoHertel/dagster
that referenced
this pull request
Feb 11, 2025
## Summary & Motivation Changes the docs to include the pools concept ## How I Tested These Changes Inspection
braunjj
pushed a commit
that referenced
this pull request
Feb 14, 2025
## Summary & Motivation Changes the docs to include the pools concept ## How I Tested These Changes Inspection
brentjericho
pushed a commit
to brentjericho/dagster
that referenced
this pull request
Feb 21, 2025
## Summary & Motivation Changes the docs to include the pools concept ## How I Tested These Changes Inspection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Changes the docs to include the pools concept
How I Tested These Changes
Inspection