Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add pool tag to display for ops / assets #26804

Merged
merged 1 commit into from
Jan 24, 2025
Merged

add pool tag to display for ops / assets #26804

merged 1 commit into from
Jan 24, 2025

Conversation

prha
Copy link
Member

@prha prha commented Jan 3, 2025 •
edited
Loading

Summary & Motivation

Adds a new PoolTag component, that is used for op / asset definition info pages to show pool concurrency status.

Screen.Recording.2025-01-09.at.5.16.20.PM.mov

How I Tested These Changes

BK, inspection

Changelog

Adds pool information in the UI for asset / op definitions that use concurrency pools.

This was referenced Jan 3, 2025
Merged
Merged
@prha Graphite App
Copy link
Member Author

prha commented Jan 3, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Jan 3, 2025
Merged
Merged
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2025 •
edited
Loading

Deploy preview for dagit-core-storybook ready!

✅ Preview
https://dagit-core-storybook-m22xy6htl-elementl.vercel.app
https://prha-ui-pool-reference.core-storybook.dagster-docs.io

Built with commit b3c25fe.
This pull request is being automatically deployed with vercel-action

@prha prha force-pushed the prha/distinguish_unconfigured_from_zero_slots branch from b677ae4 to ba46ced Compare January 6, 2025 20:04
@prha prha force-pushed the prha/ui_pool_reference branch from 18c1cfc to c01da8d Compare January 6, 2025 20:04
@prha prha force-pushed the prha/distinguish_unconfigured_from_zero_slots branch from ba46ced to 3c0b564 Compare January 6, 2025 20:52
@prha prha force-pushed the prha/ui_pool_reference branch from c01da8d to 15bc61b Compare January 6, 2025 20:52
@prha prha force-pushed the prha/distinguish_unconfigured_from_zero_slots branch from 3c0b564 to 365053a Compare January 6, 2025 22:06
@prha prha force-pushed the prha/ui_pool_reference branch from 15bc61b to 81fd01b Compare January 6, 2025 22:06
@prha prha force-pushed the prha/distinguish_unconfigured_from_zero_slots branch from 365053a to d10b8c0 Compare January 7, 2025 17:16
@prha prha force-pushed the prha/ui_pool_reference branch from 81fd01b to 948ce8f Compare January 7, 2025 17:17
@prha prha force-pushed the prha/distinguish_unconfigured_from_zero_slots branch from d10b8c0 to 05fe5ce Compare January 7, 2025 18:54
@prha prha force-pushed the prha/ui_pool_reference branch from 948ce8f to e95b257 Compare January 7, 2025 18:54
@prha prha force-pushed the prha/distinguish_unconfigured_from_zero_slots branch from 05fe5ce to e1241a5 Compare January 7, 2025 22:53
@prha prha force-pushed the prha/ui_pool_reference branch from e95b257 to 02311b6 Compare January 7, 2025 22:53
@prha prha force-pushed the prha/distinguish_unconfigured_from_zero_slots branch from e1241a5 to 4b189fe Compare January 8, 2025 04:25
@prha prha force-pushed the prha/ui_pool_reference branch from 02311b6 to fd552b6 Compare January 8, 2025 04:25
@prha prha force-pushed the prha/distinguish_unconfigured_from_zero_slots branch from 4b189fe to 68a6334 Compare January 8, 2025 04:49
@prha prha force-pushed the prha/ui_pool_reference branch 2 times, most recently from f1ee75f to 3c5deda Compare January 8, 2025 05:13
@prha prha force-pushed the prha/distinguish_unconfigured_from_zero_slots branch from 68a6334 to 103ad25 Compare January 8, 2025 05:17
@prha prha force-pushed the prha/ui_pool_reference branch from 3c5deda to 9fa4539 Compare January 8, 2025 05:17
@prha prha force-pushed the prha/distinguish_unconfigured_from_zero_slots branch from 103ad25 to b5f30e6 Compare January 8, 2025 19:52
@prha prha force-pushed the prha/ui_pool_reference branch from 9fa4539 to 16f3f44 Compare January 8, 2025 19:52
@prha prha force-pushed the prha/distinguish_unconfigured_from_zero_slots branch from b5f30e6 to 376b5b9 Compare January 8, 2025 20:36
@prha prha force-pushed the prha/ui_pool_reference branch from 16f3f44 to dc05156 Compare January 8, 2025 20:36
@prha prha mentioned this pull request Jan 9, 2025
Merged
@prha prha force-pushed the prha/distinguish_unconfigured_from_zero_slots branch from 222005b to 54f51ab Compare January 20, 2025 00:28
@vercel Vercel
Copy link

vercel bot commented Jan 20, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dagster-docs-legacy ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 20, 2025 0:40am

@prha prha force-pushed the prha/ui_pool_reference branch from 39f76f5 to dd164aa Compare January 20, 2025 00:28
@prha prha mentioned this pull request Jan 20, 2025
Merged
@prha prha force-pushed the prha/distinguish_unconfigured_from_zero_slots branch from 54f51ab to fabedb7 Compare January 21, 2025 17:58
@prha prha force-pushed the prha/ui_pool_reference branch from dd164aa to 9173c05 Compare January 21, 2025 17:58
@prha prha force-pushed the prha/distinguish_unconfigured_from_zero_slots branch from fabedb7 to 36902ba Compare January 21, 2025 19:58
@prha prha force-pushed the prha/ui_pool_reference branch from 9173c05 to d8bc41f Compare January 21, 2025 19:58
@prha prha force-pushed the prha/distinguish_unconfigured_from_zero_slots branch from 36902ba to 14bf2ee Compare January 22, 2025 01:58
@prha prha force-pushed the prha/ui_pool_reference branch from d8bc41f to eae8bea Compare January 22, 2025 01:58
@prha prha force-pushed the prha/distinguish_unconfigured_from_zero_slots branch from 14bf2ee to de0ddf9 Compare January 22, 2025 19:04
@prha prha force-pushed the prha/ui_pool_reference branch from eae8bea to e414adb Compare January 22, 2025 19:04
@prha prha force-pushed the prha/distinguish_unconfigured_from_zero_slots branch from de0ddf9 to 7c19fd1 Compare January 22, 2025 19:25
@prha prha force-pushed the prha/ui_pool_reference branch from e414adb to 0e5f295 Compare January 22, 2025 19:26
@prha prha force-pushed the prha/distinguish_unconfigured_from_zero_slots branch from 7c19fd1 to a4a9a90 Compare January 22, 2025 21:10
@prha prha force-pushed the prha/ui_pool_reference branch from 0e5f295 to b9d442e Compare January 22, 2025 21:11
@prha prha force-pushed the prha/distinguish_unconfigured_from_zero_slots branch from a4a9a90 to 83a712c Compare January 22, 2025 23:21
@prha prha force-pushed the prha/ui_pool_reference branch from b9d442e to 7d12e38 Compare January 22, 2025 23:21
@prha prha force-pushed the prha/distinguish_unconfigured_from_zero_slots branch from 83a712c to 0c6d069 Compare January 23, 2025 18:58
@prha prha force-pushed the prha/ui_pool_reference branch from 7d12e38 to 7c1087f Compare January 23, 2025 18:59
Base automatically changed from prha/distinguish_unconfigured_from_zero_slots to master January 23, 2025 19:31
@prha prha force-pushed the prha/ui_pool_reference branch from 7c1087f to 5420a74 Compare January 23, 2025 19:43
@prha
UI references to pools
b3c25fe 
[INTERNAL_BRANCH=prha/add_pool_ui_gating]
@prha prha force-pushed the prha/ui_pool_reference branch from 5420a74 to b3c25fe Compare January 23, 2025 22:09
@prha prha merged commit 071c3c7 into master Jan 24, 2025
6 checks passed
@prha prha deleted the prha/ui_pool_reference branch January 24, 2025 17:24
prha added a commit that referenced this pull request Feb 3, 2025
@prha
split out pool detailed info into a standalone settings page (#26805)
e0315e9 
## Summary & Motivation
With #26804, we're directing
more attention to the settings for specific pools.

This PR creates a new dedicated view for specific pool information (was
previously in a dialog).


https://github.com/user-attachments/assets/a34cb4c4-a541-401a-871d-16479935efc9



## How I Tested These Changes
BK

## Changelog
Creates a standalone view for specific pool info
LoHertel pushed a commit to LoHertel/dagster that referenced this pull request Feb 11, 2025
@prha @LoHertel
split out pool detailed info into a standalone settings page (dagster…
64306d8 
…-io#26805)

## Summary & Motivation
With dagster-io#26804, we're directing
more attention to the settings for specific pools.

This PR creates a new dedicated view for specific pool information (was
previously in a dialog).


https://github.com/user-attachments/assets/a34cb4c4-a541-401a-871d-16479935efc9



## How I Tested These Changes
BK

## Changelog
Creates a standalone view for specific pool info
brentjericho pushed a commit to brentjericho/dagster that referenced this pull request Feb 21, 2025
@prha @brentjericho
split out pool detailed info into a standalone settings page (dagster…
530a454 
…-io#26805)

## Summary & Motivation
With dagster-io#26804, we're directing
more attention to the settings for specific pools.

This PR creates a new dedicated view for specific pool information (was
previously in a dialog).


https://github.com/user-attachments/assets/a34cb4c4-a541-401a-871d-16479935efc9



## How I Tested These Changes
BK

## Changelog
Creates a standalone view for specific pool info
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bengotow bengotow bengotow approved these changes

@hellendag hellendag hellendag approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@prha @bengotow @hellendag