chore: port websocket in ext to bidi #31209
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cypress
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
chore/port_websocket_in_ext_to_bidi
|
| Run status |
|
| Run duration | 18m 50s |
| Commit |
|
| Committer | Bill Glesias |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
1
|
Flaky
|
7
|
Pending
|
1099
|
Skipped
|
0
|
Passing
|
26580
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
30.2%
|
|
|---|---|
|
Untested elements
|
515
|
|
Tested elements
|
219
|
Accessibility
79.57%
|
|
|---|---|
|
Failed rules
|
9 critical
14 serious
5 moderate
2 minor
|
|
Failed elements
|
1747
|
Tests for review
cypress/e2e/specs.cy.ts • 1 failed test • app-e2e
| Test | Artifacts | |
|---|---|---|
| ... > create template spec > displays alert with docs link on new spec |
Test Replay
Screenshots
|
|
commands/waiting.cy.js • 1 flaky test • 5x-driver-chrome:beta
| Test | Artifacts | |
|---|---|---|
| ... > errors > throws when waiting for 2nd response to route |
Test Replay
|
|
issues/28527.cy.ts • 1 flaky test • 5x-driver-chrome
| Test | Artifacts | |
|---|---|---|
| issue 28527 > fails and then retries and verifies about:blank is not displayed |
Test Replay
Screenshots
|
|
issues/28527.cy.ts • 1 flaky test • 5x-driver-chrome:beta
| Test | Artifacts | |
|---|---|---|
| issue 28527 > fails and then retries and verifies about:blank is not displayed |
Test Replay
Screenshots
|
|
commands/net_stubbing.cy.ts • 1 flaky test • 5x-driver-firefox
| Test | Artifacts | |||||||
|---|---|---|---|---|---|---|---|---|
| ... > stops waiting when an xhr request is canceled |
| |||||||
| Test | Artifacts | |
|---|---|---|
| src/cy/commands/files > #readFile > retries to read when ENOENT |
The first 5 flaky specs are shown, see all 7 specs in Cypress Cloud. | |
AtofStryker
force-pushed
the
chore/port_websocket_in_ext_to_bidi
branch
from
a7c7f64 to
8f73f05
Compare
AtofStryker
force-pushed
the
breaking/remove_cdp_firefox
branch
2 times, most recently
from
07c5a8e to
52676da
Compare
AtofStryker
force-pushed
the
breaking/remove_cdp_firefox
branch
from
52676da to
70e438d
Compare
AtofStryker
force-pushed
the
breaking/remove_cdp_firefox
branch
from
ee30eb9 to
425bbaa
Compare
CloneOfAlex
approved these changes
Apr 2, 2025
AtofStryker
force-pushed
the
breaking/remove_cdp_firefox
branch
2 times, most recently
from
c7f8493 to
e3bac5f
Compare
AtofStryker
force-pushed
the
chore/port_websocket_in_ext_to_bidi
branch
2 times, most recently
from
caa42e1 to
e970a54
Compare
…te cookie behavior similar to CDP client
AtofStryker
force-pushed
the
chore/port_websocket_in_ext_to_bidi
branch
from
e970a54 to
f76f89d
Compare
AtofStryker
changed the title
AtofStryker
commented
Apr 10, 2025
| @@ -122,287 +121,6 @@ describe('lib/socket', () => { | |||
| }) | |||
| }) | |||
|
|
|||
| context('on(automation:request)', () => { | |||
There was a problem hiding this comment.
Some of these tests I wanted to keep but I can't even get them to run locally
AtofStryker
commented
Apr 10, 2025
|
|
||
| // CLOSE ALL BUT THE NEW CONTEXT, which makes it active | ||
| // also do not need to navigate to about:blank as this happens by default | ||
| for (const context of contexts) { |
There was a problem hiding this comment.
TODO: add #31480 to comments
cacieprins
approved these changes
Apr 15, 2025
| return false | ||
| } | ||
|
|
||
| if (filter.path && filter.path !== cookie.path) { | ||
| if (filter?.path && !pathMatch(filter.path, cookie.path)) { |
There was a problem hiding this comment.
Is this a part of the migration? Or a separate improvement? Mostly just curious.
There was a problem hiding this comment.
its an improvement which we need since bidi cookie filter criteria is a bit different. What we really want is to check path hierarchy and not an exact match.
For instance, cookies going to request /foo should send cookies that have / or /foo as the path, but not /bar. If we are checking for strict equality on just path, only 1 of those 3 would be sent, which is incorrect. We don't notice this with CDP because it does this implicitly when we look up cookies
|
Looks good to me. Ran some e2e/ct tests and Run all specs in firefox. |
ryanthemanuel
approved these changes
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@packages/extensionmethods that are now implemented by WebDriver BiDi when BiDi is enabled #30221Additional details
Cuts over the remaining methods in the web extension that are possible (currently only used by firefox) to WebDriver BiDi. This gets us about 90% off of the websocket in the webextension via this BiDi port, which also helps us when debugging the app code in the server.
This should close the epic #29714, but does not entirely get us off the web extension for socket commands as documented in #30447 (see #30221 (comment) for more details on what is still needed and why).
Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?