Skip to content

Commit ee30eb9

Browse files
committed
chore: code review updates
1 parent 70e438d commit ee30eb9

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

Diff for: cli/CHANGELOG.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ _Released 07/01/2025 (PENDING)_
55

66
**Breaking Changes:**
77

8-
- Removed support for [Chrome DevTools Protocol](https://chromedevtools.github.io/devtools-protocol) with the [firefox](https://www.mozilla.org/) browser. Addresses []().
8+
- Removed support for [Chrome DevTools Protocol](https://chromedevtools.github.io/devtools-protocol) with the [firefox](https://www.mozilla.org/) browser. Addresses [#31189](https://github.com/cypress-io/cypress/issues/31189).
99

1010

1111
## 14.1.1

Diff for: packages/launcher/lib/known-browsers.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import type { Browser, BrowserValidatorResult, FoundBrowser } from '@packages/ty
33
const firefoxValidatorFn = (browser: FoundBrowser, platform: NodeJS.Platform): BrowserValidatorResult => {
44
try {
55
if (browser.majorVersion) {
6-
const [majorVersion] = browser.majorVersion.split('.').map(Number)
6+
const majorVersion = Number(browser.majorVersion)
77

88
if (majorVersion < 135) {
99
return {

Diff for: packages/server/lib/browsers/firefox.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -325,7 +325,7 @@ const defaultPreferences = {
325325
// CDP was deprecated in Firefox 129 and up and was removed in Firefox 141.
326326
// To enable BiDi (without CDP), we need to set
327327
// remote.active-protocol=1
328-
// In order to enable CDP (without BiDi on firefox older than version 135), we need to set
328+
// Cypress no longer supports CDP within Firefox. However, it can be enabled if needed (but only on Firefox 141 and lower) by setting
329329
// remote.active-protocol=2
330330
// both can be enabled via
331331
// remote.active-protocol=3

0 commit comments

Comments
 (0)