Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean-up top navigation settings #567

Merged
merged 4 commits into from
Jan 31, 2025
Merged

Clean-up top navigation settings #567

merged 4 commits into from
Jan 31, 2025

Conversation

bartaz
Copy link
Member

@bartaz bartaz commented Jan 29, 2025

Done

QA

  • Check demo
  • Resize screen until navigation changes to mobile view - make sure it looks fine, without anything overflowing or wrapping
  • Check the "All Canonical" navigation - it should change between desktop/mobile view at the same breakpoint as main navigation
  • Check charmhub.io navigation from this PR and demo, make sure they are consistent

Issue / Card

Part of WD-18722

Screenshots

Top nav should still be visible when items fit:
image

All canonical global nav should be in mobile mode when top nav is:
image

@webteam-app
Copy link

@bartaz bartaz marked this pull request as ready for review January 29, 2025 15:35
@bartaz
Copy link
Member Author

bartaz commented Jan 29, 2025

Needs more work, things change in navigation when you sign in to Charmhub and are affected by users name length.

@bartaz bartaz marked this pull request as ready for review January 30, 2025 11:10
Copy link
Contributor

@steverydz steverydz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@bartaz bartaz merged commit 9a70ca0 into main Jan 31, 2025
6 checks passed
@bartaz bartaz deleted the nav-fix branch January 31, 2025 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants