Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-introduce 25/75 split in the top navigation #2067

Merged
merged 2 commits into from
Jan 31, 2025
Merged

Re-introduce 25/75 split in the top navigation #2067

merged 2 commits into from
Jan 31, 2025

Conversation

bartaz
Copy link
Member

@bartaz bartaz commented Jan 29, 2025 •
edited
Loading

Done

  • re-introduces the 25/75 split in top navigation
  • Updates the navigation breakpoints to align with juju.is (Clean-up top navigation settings juju.is#567)
  • Makes sure top navigation and global-nav breakpoints are the same
  • Updates Vanilla to latest version

How to QA

  • open demo https://charmhub-io-2067.demos.haus/
  • make sure top navigation items are aligned with 75% layout of hero below
  • resize screen, make sure navigation works as expected without overflowing or wrapping
  • check "All Canonical" menu, make sure it switches between mobile and desktop view at the same time as top navigation
  • check juju.is from this PR and demo, make sure the navigations are consistent

Testing

  • This PR has tests
  • No testing required (explain why): just visual style adjustments

Issue / Card

Fixes WD-18722

Screenshots

image

@webteam-app
Copy link

Demo

Jenkins

demos.haus

@bartaz bartaz mentioned this pull request Jan 29, 2025
Merged
@bartaz bartaz marked this pull request as ready for review January 30, 2025 11:13
steverydz
steverydz approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@steverydz steverydz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@bartaz bartaz merged commit 1da66b7 into main Jan 31, 2025
13 checks passed
@bartaz bartaz deleted the nav-fixes branch January 31, 2025 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steverydz steverydz steverydz approved these changes

Assignees
No one assigned
Labels
Review: Code +1 Review: QA +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bartaz @webteam-app @steverydz