feat: add rules for ad-hoc subprocess completion configuration

[maff]

The completionCondition expression and cancelRemainingInstances attribute will only be supported in Camunda 8.8+. This PR adds support to raise an error if one of these properties is set on a lower version.

Proposed Changes

• If the cancelRemainingInstances attribute is set to true: raise an error if the version is < 8.8
• If an <bpmn:completionCondition /> element exists: raise an error if the version is < 8.8

An example process XML containing both properties:

  <bpmn:process id="Process_1" isExecutable="true">
    <bpmn:adHocSubProcess id="Activity_186wn7x" cancelRemainingInstances="false">
      <bpmn:task id="Activity_06d3rvb" name="A" />
      <bpmn:task id="Activity_1bkr1i6" name="B" />
      <bpmn:completionCondition xsi:type="bpmn:tFormalExpression">=myCondition</bpmn:completionCondition>
    </bpmn:adHocSubProcess>
  </bpmn:process>

Relates to camunda/camunda-modeler#4850.

Checklist

To ensure you provided everything we need to look at your PR:

• Brief textual description of the changes present
• Visual demo attached
• Steps to try out present, i.e. using the @bpmn-io/sr tool
• Related issue linked via Closes {LINK_TO_ISSUE} or Related to {LINK_TO_ISSUE}

[barmac]

Thanks for the contribution. So if I understand it correctly, in 8.7 we add ad-hoc subprocess support, but the completion condition and "cancel remaining instances" are not available, right?

[barmac]

Check out the comments for potential improvement. Then, we can merge the PR. Great quality of the contribution 🚀

[barmac]

Let's use the hasProperties or hasProperty helper for the checks. This decouples the error message from the rule, and also attaches the metadata (error type) consistently.

[barmac]

Example:

bpmnlint-plugin-camunda-compat/rules/camunda-cloud/subscription.js

Line 52 in 9594d50

errors = hasProperties(subscription, {

[barmac]

Another one with allowedVersion:

bpmnlint-plugin-camunda-compat/rules/camunda-cloud/no-template.js

Line 12 in 9594d50

allowedVersion: '8.0'

[maff]

Updated it to use the hasProperties check - as far as I could see the helper still needs the version check around the call as the version passed as argument is only used to generate the error message. Still needed to keep that check on the cancelRemainingInstances property being defined to achieve the desired check.

[barmac]

Scout rule - I like it :)

[maff]

Thanks for the feedback!

So if I understand it correctly, in 8.7 we add ad-hoc subprocess support, but the completion condition and "cancel remaining instances" are not available, right?

Exactly. Technically the process could be deployed on 8.7 including these attributes as they are defined in the spec, but the engine would not make use of them. Would you have concerns raising them as an error although the process can be deployed?

[barmac]

Would you have concerns raising them as an error although the process can be deployed?

I think it's the right approach. This way, we can clearly tell the user that certain features are not supported (cf. no surprises).

[barmac]

I've pushed small improvements via 7ba0097, and this is now ready to be merged. Thank you for contributing this!