Ad-Hoc Subprocess: Support completionCondition and cancelRemainingInstances attributes

[maff]

Problem you would like to solve

camunda/camunda#28220 is adding support to configure a completionCondition and a cancelRemainingInstances attribute to ad-hoc subprocesses. This should also be configurable through the properties panel in web and desktop modeler.

An example XML definition according to the BPMN spec (see page 196):

<bpmn:adHocSubProcess id="MyAdHocSubProcess" name="My Ad-Hoc Subprocess" cancelRemainingInstances="true">
    <bpmn:extensionElements>
        <zeebe:adHoc activeElementsCollection="=[&#34;A&#34;, &#34;B&#34;]"/>
    </bpmn:extensionElements>
    <!-- incoming/outgoing, tasks, ... -->
    <bpmn:completionCondition xsi:type="bpmn:tFormalExpression">=true</bpmn:completionCondition>
</bpmn:adHocSubProcess>

Proposed solution

Make the following 2 optional attributes settings configurable through the properties panel of an ad-hoc subprocess:

Attribute	Type
completionCondition	FEEL Expression (needs to resolve to boolean)
cancelRemainingInstances	Boolean (default true)

The checklist below follows the format of the issue which initially added ad-hoc subprocess support:

• Attributes can be configured in properties panel: feat: add completionCondition + cancelRemainingInstances properties to ad-hoc subprocess bpmn-io/bpmn-js-properties-panel#1114
  • completionCondition can be defined in properties panel
    • it is FEEL
    • it is optional
  • cancelRemainingInstances can be defined in properties panel
    • it is a boolean/switch
    • it defaults to true
• both attributes are supported in 8.8 config of camunda/bpmnlint-plugin-camunda-compat: feat: add rules for ad-hoc subprocess completion configuration bpmnlint-plugin-camunda-compat#196
• camunda/linting integration: Support for completionCondition and cancelRemainingInstances on ad-hoc subprocess linting#136
  • When FEEL error is clicked, the properties panel entry is focused
  • When completionCondition is set for a Camunda < 8.8 process, an error should be shown for the input
  • When cancelRemainingInstances is set for a Camunda < 8.8 process an error should be shown for the input
  • Verify the errors are human-readable
• User guidance (e.g. via tooltip) and a link to documentation is provided
  • TBD update documentation link to jump to specific documentation block?
• Make sure documentation is released together with adding the 2 new attributes - added to 8.8 docs in Add ad-hoc subprocess completion attributes camunda-docs#5235
• Integrate into camunda-bpmn-js
• Integrate into Desktop Modeler

Additional context

Needed for 8.8

[barmac]

Thanks for opening the issue. I'd like to resolve the discussion in camunda/camunda#28220 (comment) first before we move on with this.
Please note that it may be already too late to get the modeling support for 8.7 if we don't know yet whether we want it.

[barmac]

@maff @gsteyn assigning you as we agreed yesterday.

[barmac]

Not sure why this was closed even though the commit uses "Related to..." instead of "Closes...".

[barmac]

It happened again. This should not be automatically closed when a related PR is merged :/

[barmac]

@maff I've released both bpmn-js-properties-panel and bpmnlint-plugin-camunda-compat with your contributions, so you can now update the dependency in camunda/linting, and contribute the integration with the properties panel. Feel free to reach out to me if any support is needed.