Add animation transition test #18574
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greeble-dev
changed the title
alice-i-cecile
added
A-Animation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Add a test that reproduces #18557.
Solution
The test spawns several meshes, then every so often starts a new animation transition. Right now the meshes will occasionally snap due to #18557, but that will be fixed by #18572. The video is after the fix.
test_animation_transitions.mov
I'm a bit ambivalent about this test. It's quite limited, non-deterministic, and requires manual visual inspection. But it would have caught at least one bug, so maybe that's fine.
The name is debatable. I chose
test_animation_transitionsto make sure it's not confused with an example. Although it's maybe simple enough to be one - no other example shows how to manage multiple meshes playing different animations, and I suspect some people find that difficult to implement. But a real example should probably use keyboard controls instead of random timers.