Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reapply from Android Widget.__init__ #3165

Merged
merged 2 commits into from
Feb 7, 2025
Merged

Remove reapply from Android Widget.__init__ #3165

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5d2232c
Remove reapply from Android Widget.__init__
HalfWhitt Feb 6, 2025
7c508f7
Added change note
HalfWhitt Feb 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions android/src/toga_android/widgets/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,10 +63,6 @@ def __init__(self, interface):
)
)

# Immediately re-apply styles. Some widgets may defer style application until
# they have been added to a container.
self.interface.style.reapply()

@abstractmethod
def create(self): ...

Expand Down
1 change: 1 addition & 0 deletions changes/3165.misc.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
A redundant style reapplication was removed from the Android backend's Widget initializer.