Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reapply from Android Widget.__init__ #3165

Merged
merged 2 commits into from
Feb 7, 2025

Conversation

HalfWhitt
Copy link
Contributor

The comment about Android needing to reapply styles after a widget's constructed piqued my curiosity... Does it?

I'm pretty sure this is just a holdover from before #2942, when all backends had to do this.

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

@HalfWhitt
Copy link
Contributor Author

HalfWhitt commented Feb 6, 2025

With this removed, the only thing that calls reapply() — except for Pack's own reapply(), which gets around issues with deprecated aliases — is the _applicator setter in BaseStyle. Though that could potentially change, to rework around #3161.

Copy link
Member

@mhsmith mhsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure this is just a holdover from before #2942, when all backends had to do this.

I think you're probably right, and this PR doesn't break anything as far as I can tell. But I'll let @freakboy3742 check it before merging, because he's more familiar with the details of #2942.

Copy link
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed this should be redundant because of the changes in #2942; so it looks like it works in theory and practice! :-)

@freakboy3742 freakboy3742 merged commit 3977b67 into beeware:main Feb 7, 2025
49 checks passed
@HalfWhitt HalfWhitt deleted the remove-android-reapply branch February 7, 2025 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants