-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WSTEAM1-1549: Adds click view tracking to Live Header Media #12276
Merged
Isabella-Mitchell
merged 10 commits into
latest
from
WSTEAM1-1549-live-media-tracking-new
Jan 17, 2025
Merged
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
0b36f73
WSTEAM1-1549: Adds click view tracking
Isabella-Mitchell 8248426
WSTEAM1-1549: Replaces prop with constant. Updates tests
Isabella-Mitchell 46507cf
Merge branch 'latest' into WSTEAM1-1549-live-media-tracking-new
Isabella-Mitchell 3a57a66
Update src/app/components/LiveHeaderMedia/index.test.tsx
Isabella-Mitchell d37e7c6
Update src/app/components/LiveHeaderMedia/index.test.tsx
Isabella-Mitchell d298ff3
Merge in latest
Isabella-Mitchell eee09a5
WSTEAM1-1549: Remove comment
Isabella-Mitchell 97a4312
Merge branch 'latest' into WSTEAM1-1549-live-media-tracking-new
Isabella-Mitchell c43f488
Merge branch 'latest' into WSTEAM1-1549-live-media-tracking-new
Isabella-Mitchell 500e012
Merge branch 'latest' into WSTEAM1-1549-live-media-tracking-new
Isabella-Mitchell File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this expected? Or do we expect the click tracker spy not to have been called at all?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. For the tests I copied the logic used in
src/app/components/Billboard/index.test.tsx
.Since we're no longer passing in eventTrackingData in as a prop, we expect the click/ view trackers to always be called, so I suppose I can remove these tests.
All that said... I had a bit of trouble with these tests. If I follow the pattern here and call
.mockImplementation();
then I get errorError: Uncaught [TypeError: clickTrackerHandler is not a function]
. I haven't been able to work out why.