WSTEAM1-1549: Adds click view tracking to Live Header Media #12276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Isabella-Mitchell
changed the title
amoore108
reviewed
Jan 15, 2025
| ); | ||
| const playCloseButton = screen.getByTestId('watch-now-close-button'); | ||
| fireEvent.click(playCloseButton); | ||
| expect(clickTrackerSpy).toHaveBeenCalledWith(undefined); |
There was a problem hiding this comment.
Is this expected? Or do we expect the click tracker spy not to have been called at all?
There was a problem hiding this comment.
Good point. For the tests I copied the logic used in src/app/components/Billboard/index.test.tsx.
Since we're no longer passing in eventTrackingData in as a prop, we expect the click/ view trackers to always be called, so I suppose I can remove these tests.
All that said... I had a bit of trouble with these tests. If I follow the pattern here and call .mockImplementation(); then I get error Error: Uncaught [TypeError: clickTrackerHandler is not a function]. I haven't been able to work out why.
karinathomasbbc
approved these changes
Jan 16, 2025
Co-authored-by: Karina Thomas <[email protected]>
Co-authored-by: Karina Thomas <[email protected]>
amoore108
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves JIRA WSTEAM1-1549
Overall changes
Adds click and view tracking to Live Header Media 'Watch now CTA'
Code changes
Expected behaviour:
Testing
ati: PUB-[live-page]-[live-header-media]-[]-[]-[live_coverage.c7dkx155e626t.page]-[]-[]-[]atc: PUB-[live-page]-[live-header-media]-[]-[]-[live_coverage.c7dkx155e626t.page]-[]-[]-[]Helpful Links
Add Links to useful resources related to this PR if applicable.
Coding Standards
Repository use guidelines