Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky CBOR test #718

Merged
merged 1 commit into from
Mar 18, 2025
Merged

Fix flaky CBOR test #718

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/CborTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,8 +184,8 @@ static int s_decode_timestamp_helper(Cbor::CborDecoder &decoder, std::chrono::sy
{
double double_val = decoder.PopNextFloatVal().value();
std::chrono::duration<double, std::chrono::seconds::period> timestamp(double_val);
outTimePoint =
std::chrono::system_clock::time_point(std::chrono::duration_cast<std::chrono::milliseconds>(timestamp));
outTimePoint = std::chrono::system_clock::time_point(
std::chrono::duration_cast<std::chrono::system_clock::duration>(timestamp));
Comment on lines +187 to +188
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we were casting from float->int->float here, now it's float->float->float

well ... some of those "float" are weird "std chrono ratio" things, but you know what I mean

return AWS_OP_SUCCESS;
}
default:
Expand Down