Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Rare random failure of "CborTimeStampTest" (see logs)
Diagnosis:
This test does:
The flow above seems good. There are some differences in floating point precision, but we ultimately compare the values at lower precision (milliseconds-as-integer). So what's up???
Description of changes:
Fix helper function that loses lots of precision, due to too much casting back and forth between
floating-point
->integer
->floating-point
->integer
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.