(fix): Check NodePort Service Type before setting it #982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kameshsampath
requested review from
adutra,
ashvina,
dennishuo,
dimas-b,
eric-maynard,
jackye1995,
jbonofre,
vvcephei,
collado-mike,
snazy,
RussellSpitzer,
takidau,
MonkeyCanCode,
flyrain and
ebyhr
as code owners
This was referenced Feb 11, 2025
kameshsampath
force-pushed
the
issue/helm-981
branch
from
330f0a3 to
5b99cc1
Compare
kameshsampath
changed the title
adutra
requested changes
Feb 11, 2025
| @@ -90,11 +90,11 @@ spec: | |||
| mountPath: {{ .Values.logging.file.logsDir }} | |||
| readOnly: false | |||
| {{- end }} | |||
| - name: temp-dir | |||
There was a problem hiding this comment.
I think you accidentally deleted some volume mounts here. Also, there is a polaris.containerPorts template that prints the ports, you don't need to iterate over the ports here.
| targetPort: {{ .targetPort }} | ||
| {{- range $portName, $port := .Values.service.ports }} | ||
| - port: {{ $port.port }} | ||
| targetPort: {{ $port.port }} |
There was a problem hiding this comment.
It seems you accidentally modified how targetPort is handled.
| - port: 18181 | ||
| targetPort: 18181 | ||
| name: polaris-http | ||
| polaris-service: |
There was a problem hiding this comment.
This is supposed to be an array.
| - name: polaris-http | ||
| # -- The port the service listens on. By default, the HTTP port is 8181. | ||
| # polaris-server: The port the Polaris server listens on for API requests. | ||
| polaris-service: |
There was a problem hiding this comment.
This is supposed to be an array, please don't change this.
| @@ -538,6 +526,7 @@ fileIo: | |||
| # -- The type of file IO to use. Two built-in types are supported: default and wasb. The wasb one translates WASB paths to ABFS ones. | |||
| type: default | |||
|
|
|||
| <<<<<<< HEAD | |||
|
sorry some issue with my rebase. will open a new PR with #626 merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the helm chart does not support specifying arbitrary
nodePortvalue for services. This PR allows the template users to specify the nodePort for the services. Allowing nodePort helps setting the nodePort for polaris k8s deployment where we it might be a constraint to use any generated nodePort.fixes: #981