Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(fix): add conditional for nodePort check #984

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

(fix): add conditional for nodePort check #984

wants to merge 2 commits into from

Conversation

kameshsampath
Copy link

Added extra conditional check to #626 to add check to NodePort before adding the port.

fix: #981

@kameshsampath
Copy link
Author

@adutra - made clean PR over #982 to add the conditional alone.

@adutra
Copy link
Contributor

adutra commented Feb 11, 2025

Nice! Do you mind also adding a unit test to service_test.yaml? (or updating an existing test)

@adutra adutra enabled auto-merge (squash) February 12, 2025 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adutra adutra adutra approved these changes

@MonkeyCanCode MonkeyCanCode MonkeyCanCode approved these changes

@ashvina ashvina Awaiting requested review from ashvina ashvina is a code owner

@dennishuo dennishuo Awaiting requested review from dennishuo dennishuo is a code owner

@dimas-b dimas-b Awaiting requested review from dimas-b dimas-b is a code owner

@eric-maynard eric-maynard Awaiting requested review from eric-maynard eric-maynard is a code owner

@jackye1995 jackye1995 Awaiting requested review from jackye1995 jackye1995 is a code owner

@jbonofre jbonofre Awaiting requested review from jbonofre jbonofre is a code owner

@vvcephei vvcephei Awaiting requested review from vvcephei vvcephei is a code owner

@collado-mike collado-mike Awaiting requested review from collado-mike collado-mike is a code owner

@snazy snazy Awaiting requested review from snazy snazy is a code owner

@RussellSpitzer RussellSpitzer Awaiting requested review from RussellSpitzer RussellSpitzer is a code owner

@takidau takidau Awaiting requested review from takidau takidau is a code owner

@flyrain flyrain Awaiting requested review from flyrain flyrain is a code owner

@ebyhr ebyhr Awaiting requested review from ebyhr ebyhr is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Nodeport support in Helm
3 participants
@kameshsampath @adutra @MonkeyCanCode