-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Nodeport support in Helm #981
Comments
Hi, thanks for submitting this! In fact, adding a node port is already planned in the new Helm chart redesigned for Quarkus (#626): polaris/helm/polaris/values.yaml Line 103 in c64771b
The corresponding template is here:
The only difference I see with your PR #982 is that we don't test if the service type is I suggest then that we merge #626 first (I was planning to do so today anyways), then if you feel like we should enhance the templates to test the service type before printing the node port, then you could rebase your PR. Is that OK? |
@kameshsampath #626 is merged! If you want, please rebase your PR now, thanks! |
thanks @adutra - let me rebase and just add the test part |
@adutra - I rebased and pushed it back. Please review and merge if it looks good to you |
Is your feature request related to a problem? Please describe.
Currently the
service
type does not support specifying an arbitrary nodePort value for the services. Its practice with k8s deployment with Helm to allow specifying thenodePort
number.Describe the solution you'd like
The service.ports could be modified as
Then the corresponding
service
template could beWhen we run
helm template . -s templates/service.yaml -f /tmp/test-values.yaml
with test values asIt will now generate
service.yaml
like:Describe alternatives you've considered
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: