Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-45534: [C++] RunEndEncodeTableColumns should update run-end-encoded columns' schema types #45535

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+22 −1
Open

GH-45534: [C++] RunEndEncodeTableColumns should update run-end-encoded columns' schema types #45535

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion cpp/src/arrow/testing/gtest_util.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -478,17 +478,24 @@ Result<std::shared_ptr<Table>> RunEndEncodeTableColumns(
const int num_columns = table.num_columns();
std::vector<std::shared_ptr<ChunkedArray>> encoded_columns;
encoded_columns.reserve(num_columns);
std::vector<std::shared_ptr<Field>> encoded_fields;
encoded_fields.reserve(num_columns);
for (int i = 0; i < num_columns; i++) {
auto field = table.schema()->field(i);
if (std::find(column_indices.begin(), column_indices.end(), i) !=
column_indices.end()) {
ARROW_ASSIGN_OR_RAISE(auto run_end_encoded, compute::RunEndEncode(table.column(i)));
DCHECK_EQ(run_end_encoded.kind(), Datum::CHUNKED_ARRAY);
encoded_columns.push_back(run_end_encoded.chunked_array());
auto encoded_type = arrow::run_end_encoded(arrow::int32(), field->type());
encoded_fields.push_back(field->WithType(encoded_type));
} else {
encoded_columns.push_back(table.column(i));
encoded_fields.push_back(field);
}
}
return Table::Make(table.schema(), std::move(encoded_columns));
auto updated_schema = arrow::schema(encoded_fields);
return Table::Make(updated_schema, std::move(encoded_columns));
}

Result<std::optional<std::string>> PrintArrayDiff(const ChunkedArray& expected,
Expand Down
14 changes: 14 additions & 0 deletions cpp/src/arrow/testing/gtest_util_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
#include "arrow/array/builder_decimal.h"
#include "arrow/datum.h"
#include "arrow/record_batch.h"
#include "arrow/table.h"
#include "arrow/tensor.h"
#include "arrow/testing/gtest_util.h"
#include "arrow/testing/math.h"
Expand Down Expand Up @@ -281,4 +282,17 @@ TEST(AssertTestWithinUlp, Basics) {
EXPECT_FATAL_FAILURE(AssertWithinUlp(123.456f, 123.456085f, 10), "not within 10 ulps");
}

TEST(RunEndEncodeGtestUtilTest, SchemaTypeIsModified) {
std::shared_ptr<Table> table =
arrow::TableFromJSON(arrow::schema({arrow::field("col", arrow::utf8())}), {R"([
{"col": "a"},
{"col": "b"},
{"col": "c"},
{"col": "d"}
])"});
ASSERT_OK_AND_ASSIGN(std::shared_ptr<Table> ree_table,
RunEndEncodeTableColumns(*table, {0}));
ASSERT_TRUE(ree_table->schema()->field(0)->type()->Equals(
arrow::run_end_encoded(arrow::int32(), arrow::utf8())));
}
} // namespace arrow