GH-45534: [C++] RunEndEncodeTableColumns should update run-end-encoded columns' schema types
#45535
+22
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…olumns' schema types
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
This change makes the returned schema more correct pending discussion in #45534.
What changes are included in this PR?
For every column which is run-end-encoded in
RunEndEncodeTableColumns, the corresponding schema field will be changed to also be run-end-encoded.Are these changes tested?
Yes
Are there any user-facing changes?
No; this change only touches a gtest util which is not user-facing.
RunEndEncodeTableColumnsdoesn't change the table's schema type to reflect that the column is run-end-encoded #45534