Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overload * operator for BitRate and Duration #968

Closed
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions CodeGen/Generators/UnitsNetGen/QuantityGenerator.cs
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,8 @@ public QuantityGenerator(Quantity quantity)
baseDimensions.I == 0 &&
baseDimensions.Θ == 0 &&
baseDimensions.N == 0 &&
baseDimensions.J == 0;
baseDimensions.J == 0 &&
baseDimensions.b == 0;

}

Expand Down Expand Up @@ -120,7 +121,7 @@ private void GenerateStaticConstructor()
BaseDimensions = BaseDimensions.Dimensionless;
"
: $@"
BaseDimensions = new BaseDimensions({baseDimensions.L}, {baseDimensions.M}, {baseDimensions.T}, {baseDimensions.I}, {baseDimensions.Θ}, {baseDimensions.N}, {baseDimensions.J});
BaseDimensions = new BaseDimensions({baseDimensions.L}, {baseDimensions.M}, {baseDimensions.T}, {baseDimensions.I}, {baseDimensions.Θ}, {baseDimensions.N}, {baseDimensions.J}, {baseDimensions.b});
");

Writer.WL($@"
Expand Down
5 changes: 3 additions & 2 deletions CodeGen/Generators/UnitsNetWrcGen/QuantityGenerator.cs
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,8 @@ public QuantityGenerator(Quantity quantity)
baseDimensions.I == 0 &&
baseDimensions.Θ == 0 &&
baseDimensions.N == 0 &&
baseDimensions.J == 0;
baseDimensions.J == 0 &&
baseDimensions.b == 0;

}

Expand Down Expand Up @@ -114,7 +115,7 @@ private void GenerateStaticConstructor()
? @"
BaseDimensions = BaseDimensions.Dimensionless;"
: $@"
BaseDimensions = new BaseDimensions({baseDimensions.L}, {baseDimensions.M}, {baseDimensions.T}, {baseDimensions.I}, {baseDimensions.Θ}, {baseDimensions.N}, {baseDimensions.J});");
BaseDimensions = new BaseDimensions({baseDimensions.L}, {baseDimensions.M}, {baseDimensions.T}, {baseDimensions.I}, {baseDimensions.Θ}, {baseDimensions.N}, {baseDimensions.J}, {baseDimensions.b});");

Writer.WL($@"
Info = new QuantityInfo(QuantityType.{_quantity.Name}, Units.Cast<Enum>().ToArray(), BaseUnit, Zero, BaseDimensions);
Expand Down
2 changes: 2 additions & 0 deletions CodeGen/JsonTypes/BaseDimensions.cs
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@ internal class BaseDimensions
public int Θ = 0;
/// <summary>Time.</summary>
public int T = 0;
/// <summary>Information.</summary>
public int b = 0;

// 0649 Field is never assigned to
#pragma warning restore 0649
Expand Down
4 changes: 4 additions & 0 deletions Common/UnitDefinitions/BitRate.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,10 @@
"BaseUnit": "BitPerSecond",
"BaseType": "decimal",
"XmlDoc": "In telecommunications and computing, bit rate is the number of bits that are conveyed or processed per unit of time.",
"BaseDimensions": {
"b": 1,
"T": -1
},
"XmlDocRemarks": "https://en.wikipedia.org/wiki/Bit_rate",
"Units": [
{
Expand Down
3 changes: 3 additions & 0 deletions Common/UnitDefinitions/Information.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@
"BaseUnit": "Bit",
"BaseType": "decimal",
"XmlDoc": "In computing and telecommunications, a unit of information is the capacity of some standard data storage system or communication channel, used to measure the capacities of other systems and channels. In information theory, units of information are also used to measure the information contents or entropy of random variables.",
"BaseDimensions": {
"b": 1
},
"Units": [
{
"SingularName": "Byte",
Expand Down
295 changes: 199 additions & 96 deletions UnitsNet.Tests/BaseDimensionsTests.cs

Large diffs are not rendered by default.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading