-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to material3-adaptive 1.1 #1642
Closed
Closed
+263
−185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
58b1387
to
074c035
Compare
b85f29e
to
4594d18
Compare
Change-Id: I4b3b68face17149ab87135df28baa41cd5bacb0f
Change-Id: I5fba15921520bc83b13601fa82ae71457d875805
93a74b6
to
2553411
Compare
Change-Id: I8e881bb2cf549303be8612732bfb7df7555096aa
2553411
to
e25b363
Compare
Change-Id: I8e881bb2cf549303be8612732bfb7df7555096aa
5021a1c
to
502c719
Compare
dturner
approved these changes
Mar 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a couple of very minor things. Might be good to have someone else more familiar with these APIs review though.
...n/kotlin/com/google/samples/apps/nowinandroid/ui/interests2pane/InterestsListDetailScreen.kt
Outdated
Show resolved
Hide resolved
dturner
reviewed
Mar 11, 2025
...n/kotlin/com/google/samples/apps/nowinandroid/ui/interests2pane/InterestsListDetailScreen.kt
Outdated
Show resolved
Hide resolved
Change-Id: I44696efe11f8d660bb7c9dc41ade6927ce15798b
Change-Id: I5869404bc66d878030faf1ae2d5b95cc27ce67b4
@dturner I am unable to resolve all comments that were left on this PR much earlier, I'm going to close and reopen it in a new one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates material3-adaptive to 1.1, to try out the new features in Now in Android.
The main new feature is pane expansion, to allow resizing the panes with a drag handle.
To accomplish this, I've removed the nested
NavHost
setup, and replaced it with assisted injectedTopicViewModel
s for each specific topic screens. This comes with a trade-off, that while on the list-detail interests screen, swapping between different topics will build up manyViewModel
s in memory.