Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to material3-adaptive 1.1 #1642

Closed
wants to merge 10 commits into from
Closed

Conversation

alexvanyo
Copy link
Contributor

@alexvanyo alexvanyo commented Sep 27, 2024

Updates material3-adaptive to 1.1, to try out the new features in Now in Android.

The main new feature is pane expansion, to allow resizing the panes with a drag handle.

To accomplish this, I've removed the nested NavHost setup, and replaced it with assisted injected TopicViewModels for each specific topic screens. This comes with a trade-off, that while on the list-detail interests screen, swapping between different topics will build up many ViewModels in memory.

@alexvanyo alexvanyo force-pushed the av/material3-adaptive-1.1 branch from 58b1387 to 074c035 Compare November 20, 2024 00:54
@alexvanyo alexvanyo force-pushed the av/material3-adaptive-1.1 branch 2 times, most recently from b85f29e to 4594d18 Compare December 13, 2024 00:54
alexvanyo and others added 4 commits March 10, 2025 15:49
Change-Id: I4b3b68face17149ab87135df28baa41cd5bacb0f
Change-Id: I5fba15921520bc83b13601fa82ae71457d875805
@alexvanyo alexvanyo force-pushed the av/material3-adaptive-1.1 branch 2 times, most recently from 93a74b6 to 2553411 Compare March 11, 2025 15:37
Change-Id: I8e881bb2cf549303be8612732bfb7df7555096aa
@alexvanyo alexvanyo force-pushed the av/material3-adaptive-1.1 branch from 2553411 to e25b363 Compare March 11, 2025 15:39
@alexvanyo alexvanyo force-pushed the av/material3-adaptive-1.1 branch from 5021a1c to 502c719 Compare March 11, 2025 15:54
@alexvanyo alexvanyo requested a review from dturner March 11, 2025 16:38
@alexvanyo alexvanyo marked this pull request as ready for review March 11, 2025 16:38
Copy link
Collaborator

@dturner dturner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a couple of very minor things. Might be good to have someone else more familiar with these APIs review though.

Change-Id: I44696efe11f8d660bb7c9dc41ade6927ce15798b
Change-Id: I5869404bc66d878030faf1ae2d5b95cc27ce67b4
@alexvanyo alexvanyo closed this Mar 11, 2025
@alexvanyo alexvanyo reopened this Mar 11, 2025
@alexvanyo
Copy link
Contributor Author

@dturner I am unable to resolve all comments that were left on this PR much earlier, I'm going to close and reopen it in a new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants