Skip to content

Commit 502c719

Browse files
committed
Update TopicViewModelTest
Change-Id: I8e881bb2cf549303be8612732bfb7df7555096aa
1 parent af98b39 commit 502c719

File tree

1 file changed

+1
-15
lines changed

1 file changed

+1
-15
lines changed

feature/topic/src/test/kotlin/com/google/samples/apps/nowinandroid/feature/topic/TopicViewModelTest.kt

+1-15
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,6 @@
1616

1717
package com.google.samples.apps.nowinandroid.feature.topic
1818

19-
import androidx.lifecycle.SavedStateHandle
20-
import androidx.navigation.testing.invoke
2119
import com.google.samples.apps.nowinandroid.core.data.repository.CompositeUserNewsResourceRepository
2220
import com.google.samples.apps.nowinandroid.core.model.data.FollowableTopic
2321
import com.google.samples.apps.nowinandroid.core.model.data.NewsResource
@@ -26,7 +24,6 @@ import com.google.samples.apps.nowinandroid.core.testing.repository.TestNewsRepo
2624
import com.google.samples.apps.nowinandroid.core.testing.repository.TestTopicsRepository
2725
import com.google.samples.apps.nowinandroid.core.testing.repository.TestUserDataRepository
2826
import com.google.samples.apps.nowinandroid.core.testing.util.MainDispatcherRule
29-
import com.google.samples.apps.nowinandroid.feature.topic.navigation.TopicRoute
3027
import kotlinx.coroutines.flow.collect
3128
import kotlinx.coroutines.flow.combine
3229
import kotlinx.coroutines.flow.first
@@ -37,22 +34,13 @@ import kotlinx.datetime.Instant
3734
import org.junit.Before
3835
import org.junit.Rule
3936
import org.junit.Test
40-
import org.junit.runner.RunWith
41-
import org.robolectric.RobolectricTestRunner
4237
import kotlin.test.assertEquals
4338
import kotlin.test.assertIs
4439

4540
/**
4641
* To learn more about how this test handles Flows created with stateIn, see
4742
* https://developer.android.com/kotlin/flow/test#statein
48-
*
49-
* These tests use Robolectric because the subject under test (the ViewModel) uses
50-
* `SavedStateHandle.toRoute` which has a dependency on `android.os.Bundle`.
51-
*
52-
* TODO: Remove Robolectric if/when AndroidX Navigation API is updated to remove Android dependency.
53-
* * See b/340966212.
5443
*/
55-
@RunWith(RobolectricTestRunner::class)
5644
class TopicViewModelTest {
5745

5846
@get:Rule
@@ -70,12 +58,10 @@ class TopicViewModelTest {
7058
@Before
7159
fun setup() {
7260
viewModel = TopicViewModel(
73-
savedStateHandle = SavedStateHandle(
74-
route = TopicRoute(id = testInputTopics[0].topic.id),
75-
),
7661
userDataRepository = userDataRepository,
7762
topicsRepository = topicsRepository,
7863
userNewsResourceRepository = userNewsResourceRepository,
64+
topicId = testInputTopics[0].topic.id,
7965
)
8066
}
8167

0 commit comments

Comments
 (0)