-
Notifications
You must be signed in to change notification settings - Fork 61
Upgrade to symfony 7 compatibility #289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -20,19 +20,19 @@ | |
} | ||
}, | ||
"require": { | ||
"php": ">=8.0", | ||
"php": ">=8.2", | ||
"psr/http-message": "^1.0", | ||
"psr/http-client": "^1.0", | ||
"psr/http-factory": "^1.0", | ||
"psr/http-message-implementation": "^1.0|^2.0", | ||
"php-http/httplug": "^2.0", | ||
"php-http/discovery": "^1.6", | ||
"php-http/multipart-stream-builder": "^1.0", | ||
"symfony/options-resolver": "^5.4|^6.0|^7.0" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Doesn't this break the compatibility with versions older than 7.0? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Also, how does this bring compatibility with Symfony 7? It seems it was already in the list, so I don't see what it adds. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Symfony 7 needs at least PHP 8.2 |
||
"symfony/options-resolver": "^7.0" | ||
}, | ||
"require-dev": { | ||
"friendsofphp/php-cs-fixer": "^3.5", | ||
"phpunit/phpunit": "^8.0", | ||
"friendsofphp/php-cs-fixer": "^3.64", | ||
"phpunit/phpunit": "^9.0", | ||
"phpspec/phpspec": "^7.1", | ||
"symfony/yaml": "^4.2", | ||
"donatj/mock-webserver": "^2.0", | ||
|
@@ -44,7 +44,7 @@ | |
"config": { | ||
"bin-dir": "bin", | ||
"platform": { | ||
"php": "8.0" | ||
"php": "8.2" | ||
}, | ||
"allow-plugins": { | ||
"php-http/discovery": false | ||
|
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The problem in our Slack conversation seems more related to this restriction on psr/http-message where they need 2.0 or above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, so I need to upgrade psr/http-message